Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 1607633003: Code cleanup: Remove SVGInterpolation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused assertion variable to make release compile Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGElement.cpp
index c7f4aec535e431fb8df84b0da38f06d7ed66e0a8..ff9b79168baf25cada85c717b529074d6b06d24e 100644
--- a/third_party/WebKit/Source/core/svg/SVGElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGElement.cpp
@@ -33,7 +33,6 @@
#include "core/animation/ElementAnimations.h"
#include "core/animation/InterpolationEnvironment.h"
#include "core/animation/InvalidatableInterpolation.h"
-#include "core/animation/SVGInterpolation.h"
#include "core/css/CSSCursorImageValue.h"
#include "core/css/resolver/StyleResolver.h"
#include "core/dom/Document.h"
@@ -260,14 +259,8 @@ void SVGElement::applyActiveWebAnimations()
&elementAnimations()->animationStack(), nullptr, nullptr, KeyframeEffect::DefaultPriority, isSVGAttributeHandle);
for (auto& entry : activeInterpolationsMap) {
const QualifiedName& attribute = entry.key.svgAttribute();
- const Interpolation& interpolation = *entry.value.first();
- if (interpolation.isInvalidatableInterpolation()) {
- InterpolationEnvironment environment(*this, propertyFromAttribute(attribute)->baseValueBase());
- InvalidatableInterpolation::applyStack(entry.value, environment);
- } else {
- // TODO(alancutter): Remove this old code path once animations have completely migrated to InterpolationTypes.
- toSVGInterpolation(interpolation).apply(*this);
- }
+ InterpolationEnvironment environment(*this, propertyFromAttribute(attribute)->baseValueBase());
+ InvalidatableInterpolation::applyStack(entry.value, environment);
}
svgRareData()->setWebAnimatedAttributesDirty(false);
}
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698