Issue 1607613007: Regenerate .mojo file if any dependent .dart sources change

Issue 1607613007: Regenerate .mojo file if any dependent .dart sources change (Closed)

Created:
4 years, 11 months ago by Cutch

Modified:
4 years, 11 months ago

Reviewers:
alhaad, zra, tonyg

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org, ppi

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Regenerate .mojo file if any dependent .dart sources change - Fixes to snapshotter for handling absolute / symbolic link paths. - Use the depfile generated by the snapshotter to in the dartx gni rule. Fixes #612 R=tonyg@chromium.org, zra@google.com Committed: https://chromium.googlesource.com/external/mojo/+/cda76857c5aaaaafd912eddd5f0e0bb168df7fa5

Patch Set 1 #

Patch Set 2 : #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
M	mojo/dart/embedder/snapshotter/main.cc	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	mojo/public/dart/rules.gni	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	mojo/public/tools/dart_snapshotter.py	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

4 years, 11 months ago (2016-01-19 23:22:18 UTC) #9

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
cda76857c5aaaaafd912eddd5f0e0bb168df7fa5 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages