Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1607613003: Fix wrong endianness in RTCP tag calculation for AEAD/GCM. (Closed)

Created:
4 years, 11 months ago by joachim
Modified:
4 years, 9 months ago
Reviewers:
juberti2, pthatcher1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/libsrtp@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix wrong endianness in RTCP tag calculation for AEAD/GCM. The sequence number was used as little-endian when the RTCP tag was calculated which is wrong according to RFC 7714. This was fixed upstream in https://github.com/cisco/libsrtp/commit/da852b0c253f6494bd70ae254808669acea9ea63 See https://github.com/cisco/libsrtp/issues/137 for details. BUG=webrtc:5222 R=pthatcher@webrtc.org Committed: https://chromium.googlesource.com/chromium/deps/libsrtp/+/8cee0ffa9c017256c02cf9088867f92f6225ed09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M srtp/srtp/srtp.c View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
joachim
Ptal, here is another libsrtp fix that will be necessary once we support GCM ciphers ...
4 years, 11 months ago (2016-01-18 19:59:43 UTC) #2
pthatcher1
lgtm
4 years, 9 months ago (2016-03-08 22:53:32 UTC) #4
joachim
On 2016/03/08 22:53:32, pthatcher1 wrote: > lgtm Thanks. Is there a way to get a ...
4 years, 9 months ago (2016-03-09 14:11:34 UTC) #6
jiayl
4 years, 9 months ago (2016-03-09 20:33:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8cee0ffa9c017256c02cf9088867f92f6225ed09 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698