Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1607603005: Revert of Host-side implementation of ARC Intent handler (Closed)

Created:
4 years, 11 months ago by raymes
Modified:
4 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), davemoore+watch_chromium.org, oshima+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Host-side implementation of ARC Intent handler (patchset #5 id:80001 of https://codereview.chromium.org/1590723003/ ) Reason for revert: This may have broken the ChromeOS trybots: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/81609/steps/compile%20%28with%20patch%29/logs/stdio ../../chrome/browser/chromeos/arc/arc_intent_helper_bridge_impl.cc: In member function 'virtual void arc::ArcIntentHelperBridgeImpl::OnOpenUrl(const mojo::String&)': ../../chrome/browser/chromeos/arc/arc_intent_helper_bridge_impl.cc:39:16: error: no matching function for call to 'GURL::GURL(const mojo::String&)' GURL gurl(url); Original issue's description: > Host-side implementation of ARC Intent handler > > The new interface, OnOpenUrl(), is implemented in > arc_intent_helper_bridge_impl.cc. ARC-side CLs for > the interfacve are ag/845051/ and ag/845044/. > > BUG=577929 > TEST=http, https, and mailto URLs are passed from ARC > > Committed: https://crrev.com/379e0814ff680203c0b4d88cc77d339f0d03f70f > Cr-Commit-Position: refs/heads/master@{#370240} TBR=dcheng@chromium.org,hidehiko@chromium.org,lhchavez@chromium.org,xiyuan@chromium.org,yusukes@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=577929 Committed: https://crrev.com/15d94b7c0e0b17e973d144c03c7f69f9e0f62309 Cr-Commit-Position: refs/heads/master@{#370289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -214 lines) Patch
D chrome/browser/chromeos/arc/arc_intent_helper_bridge_impl.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/chromeos/arc/arc_intent_helper_bridge_impl.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/arc.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M components/arc/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M components/arc/arc_bridge_service.h View 8 chunks +0 lines, -14 lines 0 comments Download
M components/arc/arc_bridge_service.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M components/arc/arc_service_manager.h View 3 chunks +0 lines, -3 lines 0 comments Download
M components/arc/arc_service_manager.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M components/arc/common/arc_bridge.mojom View 2 chunks +0 lines, -5 lines 0 comments Download
D components/arc/common/intent_helper.mojom View 1 chunk +0 lines, -19 lines 0 comments Download
D components/arc/intent_helper/arc_intent_helper_bridge.h View 1 chunk +0 lines, -26 lines 0 comments Download
D components/arc/intent_helper/arc_intent_helper_bridge.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
raymes
Created Revert of Host-side implementation of ARC Intent handler
4 years, 11 months ago (2016-01-20 02:57:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1607603005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1607603005/1
4 years, 11 months ago (2016-01-20 02:58:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 03:01:08 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 03:02:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15d94b7c0e0b17e973d144c03c7f69f9e0f62309
Cr-Commit-Position: refs/heads/master@{#370289}

Powered by Google App Engine
This is Rietveld 408576698