Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Side by Side Diff: test/cctest/test-api.cc

Issue 16076004: fix return out of handlescope in NestedLockers (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 12038 matching lines...) Expand 10 before | Expand all | Expand 10 after
12049 static v8::Handle<Value> ThrowInJSNoCatch(const v8::Arguments& args) { 12049 static v8::Handle<Value> ThrowInJSNoCatch(const v8::Arguments& args) {
12050 CHECK(v8::Locker::IsLocked(CcTest::default_isolate())); 12050 CHECK(v8::Locker::IsLocked(CcTest::default_isolate()));
12051 ApiTestFuzzer::Fuzz(); 12051 ApiTestFuzzer::Fuzz();
12052 v8::Unlocker unlocker(CcTest::default_isolate()); 12052 v8::Unlocker unlocker(CcTest::default_isolate());
12053 const char* code = "throw 7;"; 12053 const char* code = "throw 7;";
12054 { 12054 {
12055 v8::Locker nested_locker(CcTest::default_isolate()); 12055 v8::Locker nested_locker(CcTest::default_isolate());
12056 v8::HandleScope scope(args.GetIsolate()); 12056 v8::HandleScope scope(args.GetIsolate());
12057 v8::Handle<Value> value = CompileRun(code); 12057 v8::Handle<Value> value = CompileRun(code);
12058 CHECK(value.IsEmpty()); 12058 CHECK(value.IsEmpty());
12059 return v8_str("foo"); 12059 return scope.Close(v8_str("foo"));
12060 } 12060 }
12061 } 12061 }
12062 12062
12063 12063
12064 // These are locking tests that don't need to be run again 12064 // These are locking tests that don't need to be run again
12065 // as part of the locking aggregation tests. 12065 // as part of the locking aggregation tests.
12066 TEST(NestedLockers) { 12066 TEST(NestedLockers) {
12067 v8::Locker locker(CcTest::default_isolate()); 12067 v8::Locker locker(CcTest::default_isolate());
12068 CHECK(v8::Locker::IsLocked(CcTest::default_isolate())); 12068 CHECK(v8::Locker::IsLocked(CcTest::default_isolate()));
12069 LocalContext env; 12069 LocalContext env;
(...skipping 7272 matching lines...) Expand 10 before | Expand all | Expand 10 after
19342 i::Semaphore* sem_; 19342 i::Semaphore* sem_;
19343 volatile int sem_value_; 19343 volatile int sem_value_;
19344 }; 19344 };
19345 19345
19346 19346
19347 THREADED_TEST(SemaphoreInterruption) { 19347 THREADED_TEST(SemaphoreInterruption) {
19348 ThreadInterruptTest().RunTest(); 19348 ThreadInterruptTest().RunTest();
19349 } 19349 }
19350 19350
19351 #endif // WIN32 19351 #endif // WIN32
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698