Show data usage on Site Details (MDSettings)

chrome/browser/resources/settings/site_settings/site_details.html

Index: chrome/browser/resources/settings/site_settings/site_details.html
diff --git a/chrome/browser/resources/settings/site_settings/site_details.html b/chrome/browser/resources/settings/site_settings/site_details.html
index 33d96f7440999f1d80c6fdb66918441e3ef651f1..51980000d14daa3212a735fe12d5901edb6c96bf 100644
--- a/chrome/browser/resources/settings/site_settings/site_details.html
+++ b/chrome/browser/resources/settings/site_settings/site_details.html
@@ -3,6 +3,7 @@
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
 <link rel="import" href="chrome://md-settings/site_settings/site_details_permission.html">
+<link rel="import" href="chrome://md-settings/site_settings/website_usage_private_api.html">
 
 <dom-module id="site-details">
   <link rel="import" type="css"
@@ -11,8 +12,9 @@
   <template>
     <div class="settings-box">
       <div class="origin">[[origin]]</div>
-      <h2 i18n-content="siteSettingsUsage" id="usage" hidden></h2>
-      <paper-item id="storage" hidden>
+      <h2 i18n-content="siteSettingsUsage" id="usage"
+          hidden$="[[!storedData_]]"></h2>
+      <paper-item id="storage" hidden$="[[!storedData_]]">
         <div class="flex">[[storedData_]]</div>
         <paper-icon-button icon="delete"
             on-tap="onClearStorage_"
@@ -48,6 +50,9 @@
           raised i18n-content="siteSettingsClearAndReset"
           class="reset-button"></paper-button>
     </div>
+    <website-usage-private-api id="usageApi"

[michaelpg, 2016/01/25 18:33:54]

website-usage-private-api element seems to expect to only be created once, is
that correct?

how do you enforce this (prevent people from making another site-details
instance)?

[Finnur, 2016/01/26 15:54:53]

This seems to me like a general problem with the solution proposed by Hector,
no?

I recognized a solution would be needed for the settings-site-list element as
that is created twice in the site-settings-category element, but I wasn't
planning on enforcing it for this element -- because it is designed to be used
only once. But, as you point out, I can't prevent someone in the future taking
the element and trying to create another instance.

I don't have a good answer -- not sure what construct is appropriate in
js/polymer to enforce this. Do you have any suggestions? Should we make all
these objects handle being created multiple times? Or enforce single-use by
default and just handle "duplicity" as needed?

[michaelpg, 2016/01/27 06:37:46]

I'm not sure either. I think we should raise the question on the thread. I
wouldn't block this CL on that though.

[Finnur, 2016/01/27 10:27:26]

OK, I'll bring it up.

+        website-data-usage="{{storedData_}}">
+    </website-usage-private-api>
   </template>
   <script src="site_details.js"></script>
 </dom-module>