Show data usage on Site Details (MDSettings)

chrome/test/data/webui/settings/site_details_tests.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for site-details. */
 cr.define('site_details', function() {
   function registerTests() {
     suite('SiteDetails', function() {
       /**
        * A site list element created before each test.
@@ skipping 91 matching lines @@
       setup(function() {
         PolymerTest.clearBody();
         testElement = document.createElement('site-details');
         document.body.appendChild(testElement);
       });
 
       test('empty state', function() {
         testElement.prefs = prefsEmpty;
         testElement.origin = "http://www.google.com";
 
-        // Once actual storage numbers are shown (instead of hard-coded), these
-        // two will become hidden by default.
-        assertFalse(testElement.$.usage.hidden);
-        assertFalse(testElement.$.storage.hidden);
+        assertTrue(testElement.$.usage.hidden);
+        assertTrue(testElement.$.storage.hidden);
 
         // TODO(finnur): Check for the Permission heading hiding when no
         // permissions are showing.
 
         var msg = 'No category should be showing, height';
         assertEquals(0, testElement.$.camera.offsetHeight, msg);
         assertEquals(0, testElement.$.cookies.offsetHeight, msg);
         assertEquals(0, testElement.$.fullscreen.offsetHeight, msg);
         assertEquals(0, testElement.$.geolocation.offsetHeight, msg);
         assertEquals(0, testElement.$.javascript.offsetHeight, msg);
         assertEquals(0, testElement.$.mic.offsetHeight, msg);
         assertEquals(0, testElement.$.notification.offsetHeight, msg);
         assertEquals(0, testElement.$.popups.offsetHeight, msg);
       });
 
       test('all categories visible', function() {
         testElement.prefs = prefs;
         testElement.origin = "https://foo-allow.com:443";
 
         var msg = 'All categories should be showing';
         assertNotEquals(0, testElement.$.camera.offsetHeight, msg);
         assertNotEquals(0, testElement.$.cookies.offsetHeight, msg);
         assertNotEquals(0, testElement.$.fullscreen.offsetHeight, msg);
         assertNotEquals(0, testElement.$.geolocation.offsetHeight, msg);
         assertNotEquals(0, testElement.$.javascript.offsetHeight, msg);
         assertNotEquals(0, testElement.$.mic.offsetHeight, msg);
         assertNotEquals(0, testElement.$.notification.offsetHeight, msg);
         assertNotEquals(0, testElement.$.popups.offsetHeight, msg);
       });
+
+      test('usage heading shows on storage available', function() {
+        // Remove the current website-usage-private-api element.
+        var parent = testElement.$.usageApi.parentNode;

[michaelpg, 2016/01/25 18:33:54]

see Element.prototype.remove

[Finnur, 2016/01/26 15:54:54]

Done.

[michaelpg, 2016/01/27 06:37:46]

Sorry, that was silly of me: i meant that the node, as an instance of
Element.prototype, has that function!

testElement.$.usageApi.remove();

of course what you have works exactly the same, but is more verbose than
necessary.

[Finnur, 2016/01/27 10:27:26]

Done.

+        Polymer.dom(parent).removeChild(testElement.$.usageApi);
+
+        // Replace it with a mock version.
+        Polymer({
+          is:"mock-website-usage-private-api",

[michaelpg, 2016/01/25 18:33:54]

use single quotes in JS, here & below

[michaelpg, 2016/01/25 18:33:54]

space

[Finnur, 2016/01/26 15:54:54]

Done. Here & below & above. :)

+          fetchUsageTotal: function(origin) {
+            testElement.storedData_ = '1 KB';
+          },
+        });
+        var api = document.createElement("mock-website-usage-private-api");
+        testElement.$['usageApi'] = api;

[michaelpg, 2016/01/25 18:33:54]

$.usageApi

[Finnur, 2016/01/26 15:54:54]

Done.

+        Polymer.dom(parent).appendChild(api);
+
+        testElement.prefs = prefs;
+        testElement.origin = "https://foo-allow.com:443";
+
+        assertFalse(testElement.$.usage.hidden);
+        assertFalse(testElement.$.storage.hidden);
+      });
     });
   }
   return {
     registerTests: registerTests,
   };
 });