Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1607433007: Add 'OriginAccessEntry::matchDomain'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 303f98e0c89b4ed49d6d2998b2541968559aedb1..d5f65bbc78e69588fd5b30f0b499ba6d45253de7 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -4160,7 +4160,9 @@ const KURL& Document::firstPartyForCookies() const
currentDocument = currentDocument->parentDocument();
ASSERT(currentDocument);
- if (accessEntry.matchesOrigin(*currentDocument->securityOrigin()) == OriginAccessEntry::DoesNotMatchOrigin)
+ // We use 'matchesDomain' here, as it turns out that some folks embed HTTPS login forms
+ // into HTTP pages; we should allow this kind of upgrade.
+ if (accessEntry.matchesDomain(*currentDocument->securityOrigin()) == OriginAccessEntry::DoesNotMatchOrigin)
return SecurityOrigin::urlWithUniqueSecurityOrigin();
currentDocument = currentDocument->parentDocument();
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698