Remove duplicated code in favor of IsRendererDebugURL.

Remove duplicated code in favor of IsRendererDebugURL.

BUG=none
TEST=chrome://kill and javascript: URLs still work.
R=nasko@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250871

[Charlie Reis, 2014-02-12 18:50:28]

I added IsRendererDebugURL in https://codereview.chromium.org/151593004, and I
came across a few other places it should be used.  I can file a bug if you want,
but I figure it's just a bit of code cleanup.

https://codereview.chromium.org/160743002/diff/1/content/browser/browser_url_...
File content/browser/browser_url_handler_impl.cc (left):

https://codereview.chromium.org/160743002/diff/1/content/browser/browser_url_...
content/browser/browser_url_handler_impl.cc:90: return *url ==
GURL(kChromeUICrashURL) ||
Technically this did not return true for javascript: URLs originally, but those
fall in the same spirit of the comment and I tested that they still work.

[nasko, 2014-02-12 23:27:27]

LGTM with a nit

https://codereview.chromium.org/160743002/diff/1/content/browser/webui/web_ui...
File content/browser/webui/web_ui_controller_factory_registry.cc (right):

https://codereview.chromium.org/160743002/diff/1/content/browser/webui/web_ui...
content/browser/webui/web_ui_controller_factory_registry.cc:87: // javascript:
and debug URLs liks chrome://kill are allowed.
nit: s/liks/like/

[Charlie Reis, 2014-02-12 23:41:25]

https://codereview.chromium.org/160743002/diff/1/content/browser/webui/web_ui...
File content/browser/webui/web_ui_controller_factory_registry.cc (right):

https://codereview.chromium.org/160743002/diff/1/content/browser/webui/web_ui...
content/browser/webui/web_ui_controller_factory_registry.cc:87: // javascript:
and debug URLs liks chrome://kill are allowed.
On 2014/02/12 23:27:29, nasko wrote:
> nit: s/liks/like/

Oops, thanks.  Fixed.

[Charlie Reis, 2014-02-12 23:41:32]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2014-02-12 23:43:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/creis@chromium.org/160743002/170001

[commit-bot: I haz the power, 2014-02-13 00:23:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 00:23:29]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, base_unittests, browser_tests,
cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git,
chrome_elf_unittests, chromedriver_unittests, components_unittests,
compositor_unittests, content_browsertests, content_unittests, crypto_unittests,
events_unittests, google_apis_unittests, gpu_unittests,
installer_util_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, mini_installer_test, nacl_integration, net_unittests,
ppapi_unittests, printing_unittests, remoting_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, telemetry_perf_unittests,
telemetry_unittests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Charlie Reis, 2014-02-13 00:52:17]

Committed patchset #2 manually as r250871 (presubmit successful).