tools/gn/ninja_target_writer.cc - Issue 1607423002: Allow .o files for GN generated inputs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 1607423002: Allow .o files for GN generated inputs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_target_writer.cc

diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc

index d3902c5d9e27cae8255b2a6bd5d095e2b4fa1cc1..6c5d12b05c020e52bc9f6aaa587363dae4165d82 100644

--- a/tools/gn/ninja_target_writer.cc

+++ b/tools/gn/ninja_target_writer.cc

@@ -67,11 +67,7 @@ void NinjaTargetWriter::RunAndWriteFile(const Target* target) {

} else if (target->output_type() == Target::GROUP) {

NinjaGroupTargetWriter writer(target, file);

writer.Run();

- } else if (target->output_type() == Target::EXECUTABLE ||

- target->output_type() == Target::LOADABLE_MODULE ||

- target->output_type() == Target::STATIC_LIBRARY ||

- target->output_type() == Target::SHARED_LIBRARY ||

- target->output_type() == Target::SOURCE_SET) {

+ } else if (target->IsBinary()) {

NinjaBinaryTargetWriter writer(target, file);

writer.Run();

} else {

« no previous file with comments | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/target.h » ('j') | no next file with comments »