Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 1607423002: Allow .o files for GN generated inputs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/ninja_binary_target_writer.cc ('K') | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/target.h » ('j') | tools/gn/target.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_target_writer.cc
diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc
index d3902c5d9e27cae8255b2a6bd5d095e2b4fa1cc1..6c5d12b05c020e52bc9f6aaa587363dae4165d82 100644
--- a/tools/gn/ninja_target_writer.cc
+++ b/tools/gn/ninja_target_writer.cc
@@ -67,11 +67,7 @@ void NinjaTargetWriter::RunAndWriteFile(const Target* target) {
} else if (target->output_type() == Target::GROUP) {
NinjaGroupTargetWriter writer(target, file);
writer.Run();
- } else if (target->output_type() == Target::EXECUTABLE ||
brettw 2016/01/20 20:45:29 This code moved to a helper function on Target.
- target->output_type() == Target::LOADABLE_MODULE ||
- target->output_type() == Target::STATIC_LIBRARY ||
- target->output_type() == Target::SHARED_LIBRARY ||
- target->output_type() == Target::SOURCE_SET) {
+ } else if (target->IsBinary()) {
NinjaBinaryTargetWriter writer(target, file);
writer.Run();
} else {
« tools/gn/ninja_binary_target_writer.cc ('K') | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/target.h » ('j') | tools/gn/target.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698