Allow .o files for GN generated inputs.

Allow .o files for GN generated inputs.

GN checks inputs and sources for files that are in the build directory, and
requires those files be generated by a dependency of the target.

Previously, only the final outputs of a target were considered. But NaCl wants
to compile some CRT code and take one of the intermediate object files as
inputs to a subsequent action. The current code was not aware of the generated
object files.

This patch will check for generated object files when the normal checks for
generated inputs fails.

BUG=579629
Committed: https://crrev.com/65e89854f57ac34a51e4c60ac663ce21110e6944
Cr-Commit-Position: refs/heads/master@{#370539}

[brettw, 2016-01-20 20:45:29]

brettw@chromium.org changed reviewers:
+ phosek@chromium.org

[brettw, 2016-01-20 20:45:29]

Turns out this did not intersect with James' patch so I just fixed the issue
properly instead of doing the .o whitelist we discussed as a temporary measure.

https://codereview.chromium.org/1607423002/diff/1/tools/gn/ninja_binary_targe...
File tools/gn/ninja_binary_target_writer.cc (left):

https://codereview.chromium.org/1607423002/diff/1/tools/gn/ninja_binary_targe...
tools/gn/ninja_binary_target_writer.cc:95: // Computes the set of output files
resulting from compiling the given source
This was moved to a member function on Target.

https://codereview.chromium.org/1607423002/diff/1/tools/gn/ninja_target_write...
File tools/gn/ninja_target_writer.cc (left):

https://codereview.chromium.org/1607423002/diff/1/tools/gn/ninja_target_write...
tools/gn/ninja_target_writer.cc:70: } else if (target->output_type() ==
Target::EXECUTABLE ||
This code moved to a helper function on Target.

[brettw, 2016-01-20 20:45:32]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 20:45:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607423002/1

[commit-bot: I haz the power, 2016-01-20 21:35:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 21:35:18]

Dry run: This issue passed the CQ dry run.

[Petr Hosek, 2016-01-20 21:40:11]

lgtm

https://codereview.chromium.org/1607423002/diff/1/tools/gn/target.h
File tools/gn/target.h (right):

https://codereview.chromium.org/1607423002/diff/1/tools/gn/target.h#newcode70
tools/gn/target.h:70: // True for targets that compile source code (alltyeps of
libaries and
Nit: a typo "all types"

[brettw, 2016-01-20 22:11:41]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-01-20 22:11:41]

The patchset sent to the CQ was uploaded after l-g-t-m from phosek@chromium.org
Link to the patchset: https://codereview.chromium.org/1607423002/#ps20001
(title: "Comment fix")

[commit-bot: I haz the power, 2016-01-20 22:12:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607423002/20001

[commit-bot: I haz the power, 2016-01-20 23:58:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-21 00:00:15]

Description was changed from

==========
Allow .o files for GN generated inputs.

GN checks inputs and sources for files that are in the build directory, and
requires those files be generated by a dependency of the target.

Previously, only the final outputs of a target were considered. But NaCl wants
to compile some CRT code and take one of the intermediate object files as
inputs to a subsequent action. The current code was not aware of the generated
object files.

This patch will check for generated object files when the normal checks for
generated inputs fails.

BUG=579629
==========

to

==========
Allow .o files for GN generated inputs.

GN checks inputs and sources for files that are in the build directory, and
requires those files be generated by a dependency of the target.

Previously, only the final outputs of a target were considered. But NaCl wants
to compile some CRT code and take one of the intermediate object files as
inputs to a subsequent action. The current code was not aware of the generated
object files.

This patch will check for generated object files when the normal checks for
generated inputs fails.

BUG=579629

Committed: https://crrev.com/65e89854f57ac34a51e4c60ac663ce21110e6944
Cr-Commit-Position: refs/heads/master@{#370539}
==========

[commit-bot: I haz the power, 2016-01-21 00:00:16]

Patchset 2 (id:??) landed as
https://crrev.com/65e89854f57ac34a51e4c60ac663ce21110e6944
Cr-Commit-Position: refs/heads/master@{#370539}