MD History: Display synced tabs history

chrome/browser/resources/md_history/history.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Globals:
 /** @const */ var RESULTS_PER_PAGE = 150;
 
 /**
  * Amount of time between pageviews that we consider a 'break' in browsing,
  * measured in milliseconds.
  * @const
  */
 var BROWSING_GAP_TIME = 15 * 60 * 1000;
 
-window.addEventListener('load', function() {
-  chrome.send('queryHistory', ['', 0, 0, 0, RESULTS_PER_PAGE]);
-});
-
 /**
  * Listens for history-item being selected or deselected (through checkbox)
  * and changes the view of the top toolbar.
  */
 window.addEventListener('history-checkbox-select', function(e) {
   $('toolbar').count += e.detail.countAddition;
 });
 
 /**
  * Listens for call to cancel selection and loops through all items to set
@@ skipping 31 matching lines @@
   }
 });
 
 /**
  * Resizing browser window will cause the overflow menu to close.
  */
 window.addEventListener('resize', function() {
   $('history-card-manager').closeMenu();
 });
 
+/**
+ * Switches between displaying history data and synced tabs data for the page.
+ */
+window.addEventListener('switch-display', function(e) {
+  $('synced-device-manager').hidden = e.detail.display == 'history-button';
+  $('history-card-manager').hidden = e.detail.display == 'synced-tabs-button';

[calamity, 2016/02/11 00:23:31]

Invert this.

$('synced..').hidden = ... != 'synced..'

Then the line is generalizable for other pages! So elegant. Much wow.

[yingran, 2016/02/11 02:06:36]

Done.

+});
+
+window.addEventListener('load', function() {
+  chrome.send('queryHistory', ['', 0, 0, 0, RESULTS_PER_PAGE]);
+  chrome.send('getForeignSessions');
+});
+
 // Chrome Callbacks-------------------------------------------------------------
 
 /**
  * Our history system calls this function with results from searches.
  * @param {HistoryQuery} info An object containing information about the query.
  * @param {Array<HistoryEntry>} results A list of results.
  */
 function historyResult(info, results) {
   $('history-card-manager').addNewResults(results);
 }
 
 /**
+ * Receives the synced history data. An empty list means that either there are
+ * no foreign sessions, or tab sync is disabled for this profile.
+ * |isTabSyncEnabled| makes it possible to distinguish between the cases.
+ *
+ * @param {Array} sessionList Array of objects describing the sessions
+ *     from other devices.
+ * @param {boolean} isTabSyncEnabled Is tab sync enabled for this profile?
+ */
+function setForeignSessions(sessionList, isTabSyncEnabled) {
+  if (isTabSyncEnabled) {
+    $('synced-device-manager').addSyncedHistory(sessionList);
+    $('side-bar').hidden = false;
+  } else {
+    $('side-bar').hidden = true;
+  }

[calamity, 2016/02/11 00:23:31]

This whole thing would be shorter if you extracted $().hidden =
!isTabSyncEnabled.

[yingran, 2016/02/11 02:06:36]

Done.

+}
+
+/**
  * Called by the history backend when deletion was succesful.
  */
 function deleteComplete() {
   $('history-card-manager').removeDeletedHistory($('toolbar').count);
   $('toolbar').count = 0;
 }
 
 /**
  * Called by the history backend when the deletion failed.
  */
 function deleteFailed() {
 }
 
 /**
  * Called when the history is deleted by someone else.
  */
 function historyDeleted() {
 }