Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1607323003: [ll_prof] show tick count (Closed)

Created:
4 years, 11 months ago by Mircea Trofin
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ll_prof] show tick count Show tick count, besides the percentage spent on an instruction. Aids perf investigations where we deal with stalls, for example. Percentage-wise, the execution appears distributed similarly, but the regression becomes more apparent in the tick counts. Committed: https://crrev.com/018a1f886e9b5e554101a827b72008591ee272ee Cr-Commit-Position: refs/heads/master@{#33452}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M tools/ll_prof.py View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Mircea Trofin
4 years, 11 months ago (2016-01-22 00:04:55 UTC) #4
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-22 05:15:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1607323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1607323003/20001
4 years, 11 months ago (2016-01-22 05:23:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 11 months ago (2016-01-22 05:42:21 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 05:43:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/018a1f886e9b5e554101a827b72008591ee272ee
Cr-Commit-Position: refs/heads/master@{#33452}

Powered by Google App Engine
This is Rietveld 408576698