Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 16073010: ReturnValue::Set needs to check for empty handles (Closed)

Created:
7 years, 6 months ago by dcarney
Modified:
7 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

ReturnValue::Set needs to check for empty handles R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14898

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M include/v8.h View 1 chunk +10 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 6 months ago (2013-05-31 11:02:51 UTC) #1
Jakob Kummerow
lgtm
7 years, 6 months ago (2013-05-31 11:05:41 UTC) #2
dcarney
7 years, 6 months ago (2013-05-31 11:06:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14898 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698