Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 16073002: components: Move web_contents_delegate_android into web_contents_delegate_android namespace. (Closed)

Created:
7 years, 7 months ago by tfarina
Modified:
7 years, 6 months ago
Reviewers:
Lei Zhang, joth, Jói
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

components: Move web_contents_delegate_android into web_contents_delegate_android namespace. BUG=238224 R=joi@chromium.org, joth@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202981

Patch Set 1 #

Patch Set 2 : fix android java #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M android_webview/lib/main/webview_entry_point.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_web_contents_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java View 1 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java View 1 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android/color_chooser_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/web_contents_delegate_android/color_chooser_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/web_contents_delegate_android/component_jni_registrar.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_contents_delegate_android/component_jni_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
Joi components, overall. Lei chrome. Jonathan android_webview. Please, take a look. Thanks,
7 years, 7 months ago (2013-05-26 16:12:29 UTC) #1
tfarina
Jonathan, do you know about the android failure?
7 years, 7 months ago (2013-05-26 23:35:18 UTC) #2
Jói
LGTM, modulo bot failure.
7 years, 7 months ago (2013-05-27 10:52:02 UTC) #3
joth
On 2013/05/26 23:35:18, tfarina wrote: > Jonathan, do you know about the android failure? You'll ...
7 years, 7 months ago (2013-05-27 20:36:14 UTC) #4
Lei Zhang
chrome/ lgtm
7 years, 7 months ago (2013-05-28 06:58:05 UTC) #5
tfarina
Done. Jonathan, please take another look at the Java changes. Thanks,
7 years, 6 months ago (2013-05-29 13:54:55 UTC) #6
joth
lgtm
7 years, 6 months ago (2013-05-29 18:29:39 UTC) #7
tfarina
7 years, 6 months ago (2013-05-29 21:39:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r202981 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698