Add gpu implementation of OverdrawXfermode

Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607253002

Committed: https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba

Committed: https://skia.googlesource.com/skia/+/f42fca4027ed4f235ef927786813a5ed0e6652b9

[robertphillips, 2016-01-20 13:39:04]

Description was changed from

==========
Add gpu implementation of OverdrawXfermode
==========

to

==========
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-01-20 13:40:33]

Description was changed from

==========
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-01-20 13:40:33]

robertphillips@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2016-01-20 14:28:35]

https://codereview.chromium.org/1607253002/diff/1/src/utils/debugger/SkOverdr...
File src/utils/debugger/SkOverdrawMode.cpp (right):

https://codereview.chromium.org/1607253002/diff/1/src/utils/debugger/SkOverdr...
src/utils/debugger/SkOverdrawMode.cpp:151: return
GrXferProcessor::kNone_OptFlags;
I think this can return ignore color right?

https://codereview.chromium.org/1607253002/diff/1/src/utils/debugger/SkOverdr...
src/utils/debugger/SkOverdrawMode.cpp:183: if (proc.dstReadUsesMixedSamples()) {
Instead of copying and pasting this code into almost every xp, can we share it
in the base class? The annoying part is CoverageSetOp handles coverage
differently than everyone else

https://codereview.chromium.org/1607253002/diff/1/src/utils/debugger/SkOverdr...
src/utils/debugger/SkOverdrawMode.cpp:286: ++idx;
Why is this +1 here? Why not either get right of the 0 row of gTable or hardcode
the +1 into the idx calculations above?

[robertphillips, 2016-01-20 15:45:10]

https://codereview.chromium.org/1607253002/diff/1/src/utils/debugger/SkOverdr...
File src/utils/debugger/SkOverdrawMode.cpp (right):

https://codereview.chromium.org/1607253002/diff/1/src/utils/debugger/SkOverdr...
src/utils/debugger/SkOverdrawMode.cpp:151: return
GrXferProcessor::kNone_OptFlags;
On 2016/01/20 14:28:34, egdaniel wrote:
> I think this can return ignore color right?

Done.

https://codereview.chromium.org/1607253002/diff/1/src/utils/debugger/SkOverdr...
src/utils/debugger/SkOverdrawMode.cpp:183: if (proc.dstReadUsesMixedSamples()) {
On 2016/01/20 14:28:34, egdaniel wrote:
> Instead of copying and pasting this code into almost every xp, can we share it
> in the base class? The annoying part is CoverageSetOp handles coverage
> differently than everyone else

Done.

https://codereview.chromium.org/1607253002/diff/1/src/utils/debugger/SkOverdr...
src/utils/debugger/SkOverdrawMode.cpp:286: ++idx;
On 2016/01/20 14:28:34, egdaniel wrote:
> Why is this +1 here? Why not either get right of the 0 row of gTable or
hardcode
> the +1 into the idx calculations above?

Done. Here and in the gpu implementation.

[egdaniel, 2016-01-20 15:46:59]

lgtm

[robertphillips, 2016-01-20 15:47:30]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 15:47:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607253002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607253002/20001

[commit-bot: I haz the power, 2016-01-20 15:48:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 15:48:25]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[robertphillips, 2016-01-20 15:52:01]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 15:52:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607253002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607253002/40001

[commit-bot: I haz the power, 2016-01-20 15:57:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 15:57:03]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[robertphillips, 2016-01-20 16:54:56]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 16:55:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607253002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607253002/60001

[commit-bot: I haz the power, 2016-01-20 17:06:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 17:06:17]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-01-20 18:34:56]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-01-20 18:34:56]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1607253002/#ps60001
(title: "Fix factory count check")

[commit-bot: I haz the power, 2016-01-20 18:35:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607253002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607253002/60001

[robertphillips, 2016-01-20 18:35:25]

The CQ bit was unchecked by robertphillips@google.com

[robertphillips, 2016-01-20 19:38:47]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 19:38:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607253002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607253002/100001

[commit-bot: I haz the power, 2016-01-20 19:55:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 19:55:17]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-01-20 19:56:35]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-01-20 19:56:35]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1607253002/#ps100001
(title: "Update factory counts")

[commit-bot: I haz the power, 2016-01-20 19:56:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607253002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607253002/100001

[commit-bot: I haz the power, 2016-01-20 20:00:23]

Description was changed from

==========
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba
==========

[commit-bot: I haz the power, 2016-01-20 20:00:24]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba

[robertphillips, 2016-01-22 14:27:41]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1626443002/ by robertphillips@google.com.

The reason for reverting is: Overdraw Xfer mode using new fangled glsl features
.

[robertphillips, 2016-01-25 17:58:01]

Description was changed from

==========
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba
==========

to

==========
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba
==========

[robertphillips, 2016-01-26 21:14:20]

PTAL - this should now address the GLSL 1.10 compatibility issues

[egdaniel, 2016-01-26 21:37:08]

lgtm

[robertphillips, 2016-01-27 12:41:53]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 12:42:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607253002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607253002/140001

[commit-bot: I haz the power, 2016-01-27 12:53:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 12:53:55]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-01-27 12:59:21]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-01-27 12:59:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607253002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607253002/140001

[commit-bot: I haz the power, 2016-01-27 13:00:07]

Description was changed from

==========
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba
==========

to

==========
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba

Committed:
https://skia.googlesource.com/skia/+/f42fca4027ed4f235ef927786813a5ed0e6652b9
==========

[commit-bot: I haz the power, 2016-01-27 13:00:08]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/f42fca4027ed4f235ef927786813a5ed0e6652b9