third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp - Issue 1607213002: Prevent copyTextTo() from Breaking Code Points

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

Issue 1607213002: Prevent copyTextTo() from Breaking Code Points (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp b/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

index 9706da369f11217d1d64e4f72c82fbaf39c008b0..3688dde7c1d952dfdd182ba5a18e16b7d2875745 100644

--- a/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

@@ -1105,6 +1105,13 @@ bool TextIteratorAlgorithm<Strategy>::isInTextSecurityMode() const

return isTextSecurityNode(node());

}

+template <typename Strategy>

+bool TextIteratorAlgorithm<Strategy>::isBetweenSurrogatePair(int position) const

+ ASSERT(position >= 0);

+ return position > 0 && position < length() && U16_IS_LEAD(characterAt(position - 1)) && U16_IS_TRAIL(characterAt(position));

// --------

template <typename Strategy>