Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 16072010: Disable the sign-in command when incognito mode is forced. (Closed)

Created:
7 years, 6 months ago by Joao da Silva
Modified:
7 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Disable the sign-in command when incognito mode is forced. The sign-in flow always opens in a non-incognito window, and should be disabled when only incognito is allowed. BUG=244246 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203127

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/browser_command_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Joao da Silva
Peter, please have a look. Thanks!
7 years, 6 months ago (2013-05-29 11:41:45 UTC) #1
Peter Kasting
LGTM
7 years, 6 months ago (2013-05-29 18:19:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/16072010/1
7 years, 6 months ago (2013-05-30 00:10:05 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 12:30:11 UTC) #4
Message was sent while issue was closed.
Change committed as 203127

Powered by Google App Engine
This is Rietveld 408576698