Issue 16072003: Fix module dependency in file_system_url*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16072003: Fix module dependency in file_system_url* (Closed)

Created:
7 years, 7 months ago by kinuko

Modified:
7 years, 7 months ago

Reviewers:
tzik

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, nhiroki, calvinlo

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix module dependency in file_system_url* FileSystemURL should no longer have dependencies to IsolatedContext or ExternalMountPoints, but should be just a simple class. Remove unnecessary header files and move tests that are specific to SyncableFileSystem into webkit/fileapi/syncable/syncable_file_system_util_unittest.cc. BUG=239710, 240658 TEST=FileSystemURLTest.*,SyncableFileSystemTest.SyncableFileSystemURL_IsParent R=tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202372

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -50 lines)			Patch
M	webkit/fileapi/file_system_url.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/fileapi/file_system_url_unittest.cc	View	5 chunks	+7 lines, -48 lines	0 comments	Download
M	webkit/fileapi/syncable/syncable_file_system_util_unittest.cc	View	2 chunks	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kinuko

Slightly updated the issue description, as it looks we can have this in webkit/browser module ...

7 years, 7 months ago (2013-05-27 02:52:19 UTC) #2

kinuko

7 years, 7 months ago (2013-05-27 05:51:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r202372 (presubmit successful).

Expand Messages | Collapse Messages