Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 16072002: chrome/browser: Remove unnecessary entries from DEPS files. (Closed)

Created:
7 years, 7 months ago by tfarina
Modified:
7 years, 6 months ago
Reviewers:
Lei Zhang, Jói
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

chrome/browser: Remove unnecessary entries from DEPS files. After recent refactorings chrome/browser/api and a few chrome/browser/profiles/ includes are not necessary anymore. c/b/api was removed in r195919 by Peter and some c/b/profiles/ were moved in r201167 by Pawel. BUG=138280, 144783, 140037, 144050, 146851, 233552 TEST=checkdeps.py passes. R=joi@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202729

Patch Set 1 #

Total comments: 1

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M WATCHLISTS View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/common/DEPS View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/common/README View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/favicon/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/browser/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Hey Joi, sorry I wasn't able to send this yesterday because I'm moving to another ...
7 years, 7 months ago (2013-05-26 15:06:48 UTC) #1
Jói
LGTM, thanks Thiago.
7 years, 7 months ago (2013-05-27 10:50:30 UTC) #2
Lei Zhang
lgtm with nit below. https://codereview.chromium.org/16072002/diff/1/chrome/browser/common/DEPS File chrome/browser/common/DEPS (right): https://codereview.chromium.org/16072002/diff/1/chrome/browser/common/DEPS#newcode3 chrome/browser/common/DEPS:3: # browser. So it should ...
7 years, 6 months ago (2013-05-28 02:09:47 UTC) #3
tfarina
7 years, 6 months ago (2013-05-29 01:07:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r202729 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698