Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1607193003: [debugger] remove break point hit count and ignore count. (Closed)

Created:
4 years, 11 months ago by Yang
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] remove break point hit count and ignore count. These features are not used by devtools and consequently not exposed through the devtools protocol. They make the debugger unnecessarily complex. If we decide that we need this, we should implement this on a higher layer. R=bmeurer@chromium.org Committed: https://crrev.com/fe19b11e53dcda9050d4ef8e6e0b2902ba04b5f0 Cr-Commit-Position: refs/heads/master@{#33436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -272 lines) Patch
M src/debug/debug.js View 18 chunks +0 lines, -81 lines 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +0 lines, -78 lines 0 comments Download
M test/mjsunit/debug-changebreakpoint.js View 1 chunk +0 lines, -6 lines 0 comments Download
M test/mjsunit/debug-conditional-breakpoints.js View 11 chunks +0 lines, -17 lines 0 comments Download
D test/mjsunit/debug-ignore-breakpoints.js View 1 chunk +0 lines, -88 lines 0 comments Download
M test/mjsunit/debug-setbreakpoint.js View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
4 years, 11 months ago (2016-01-20 07:50:51 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1607193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1607193003/1
4 years, 11 months ago (2016-01-20 10:14:44 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-20 10:38:44 UTC) #5
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-20 11:38:58 UTC) #6
Benedikt Meurer
I think this is landable now.
4 years, 11 months ago (2016-01-21 12:27:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1607193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1607193003/1
4 years, 11 months ago (2016-01-21 12:53:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 13:14:50 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 13:15:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe19b11e53dcda9050d4ef8e6e0b2902ba04b5f0
Cr-Commit-Position: refs/heads/master@{#33436}

Powered by Google App Engine
This is Rietveld 408576698