Tweak reflective_tests _invokeSymbolIfExists to not swallow exceptions

Tweak reflective_tests _invokeSymbolIfExists to not swallow exceptions

I had a bug in my code, that caused a bunch of test failures without meaningful stack trace. It was caused by _invokeSymbolIfExists swallowing all NoSuchMethodErrors from setUp/tearDown calls. Instead, it now guards only the method lookup, not the call.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/0b407a2c6180c3a490005b58d7df9f04cce7da15

[Jennifer Messerly, 2016-01-19 23:51:02]

Description was changed from

==========
Tweak reflective_tests _invokeSymbolIfExists to not swallow exceptions

I has a bug in some code, but it caused a bunch of test failures without
meaningful stack trace. It was caused by swallowing all nSM errors from
setUp/tearDown. Instead, it now guards only the method lookup, not the call.
==========

to

==========
Tweak reflective_tests _invokeSymbolIfExists to not swallow exceptions

I had a bug in my code, that caused a bunch of test failures without meaningful
stack trace. It was caused by _invokeSymbolIfExists swallowing all
NoSuchMethodErrors from setUp/tearDown calls. Instead, it now guards only the
method lookup, not the call.
==========

[Jennifer Messerly, 2016-01-19 23:51:02]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com

[Jennifer Messerly, 2016-01-19 23:53:54]

https://codereview.chromium.org/1607103003/diff/1/pkg/analyzer/test/reflectiv...
File pkg/analyzer/test/reflective_tests.dart (right):

https://codereview.chromium.org/1607103003/diff/1/pkg/analyzer/test/reflectiv...
pkg/analyzer/test/reflective_tests.dart:78: closure =
instanceMirror.getField(symbol);
Basically, we get the tearoff:
https://api.dartlang.org/1.13.2/dart-mirrors/ObjectMirror/getField.html

[Brian Wilkerson, 2016-01-20 00:14:00]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2016-01-20 00:14:00]

LGTM, but Konstantin knows this code better than I do.

[scheglov, 2016-01-20 00:17:43]

LGTM

[Jennifer Messerly, 2016-01-20 21:39:04]

Description was changed from

==========
Tweak reflective_tests _invokeSymbolIfExists to not swallow exceptions

I had a bug in my code, that caused a bunch of test failures without meaningful
stack trace. It was caused by _invokeSymbolIfExists swallowing all
NoSuchMethodErrors from setUp/tearDown calls. Instead, it now guards only the
method lookup, not the call.
==========

to

==========
Tweak reflective_tests _invokeSymbolIfExists to not swallow exceptions

I had a bug in my code, that caused a bunch of test failures without meaningful
stack trace. It was caused by _invokeSymbolIfExists swallowing all
NoSuchMethodErrors from setUp/tearDown calls. Instead, it now guards only the
method lookup, not the call.

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0b407a2c6180c3a490005b58d7df9f04cce7da15
==========

[Jennifer Messerly, 2016-01-20 21:39:05]

Committed patchset #1 (id:1) manually as
0b407a2c6180c3a490005b58d7df9f04cce7da15 (presubmit successful).