Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1607073002: Fixes #412 (Closed)

Created:
4 years, 11 months ago by vsm
Modified:
4 years, 11 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org, devoncarew
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes #412 Adds Screen, Navigator.language, and HTMLHtmlElement to dart:html R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/779b1944d59837ccc640515c21a6eb8aa76dd2fd

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -69 lines) Patch
M lib/runtime/dart/html.js View 7 chunks +93 lines, -2 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/collection/wrappers.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tool/input_sdk/lib/html/ddc/html_ddc.dart View 8 chunks +113 lines, -0 lines 0 comments Download
M tool/sdk_expected_errors.txt View 2 chunks +60 lines, -60 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 11 months ago (2016-01-19 19:33:36 UTC) #3
Jacob
lgtm
4 years, 11 months ago (2016-01-19 21:27:32 UTC) #4
vsm
4 years, 11 months ago (2016-01-19 21:31:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
779b1944d59837ccc640515c21a6eb8aa76dd2fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698