chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java - Issue 1607043002: Only show cast button if video can be cast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java

Issue 1607043002: Only show cast button if video can be cast (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix null pointer error (found by telemetry smoke tests!) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaRouteController.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java

index 50cbae16003582a8be0a94c347ba312b6df12095..0c9e7b37bbce9b6225cc710787747102640abb72 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java

@@ -60,7 +60,7 @@ public class MediaUrlResolver extends AsyncTask<Void, Void, MediaUrlResolver.Res

* @param uri the resolved URL.

- void setUri(Uri uri, boolean palyable);

+ void deliverResult(Uri uri, boolean palyable);

}

@@ -174,7 +174,7 @@ public class MediaUrlResolver extends AsyncTask<Void, Void, MediaUrlResolver.Res

protected void onPostExecute(MediaUrlResolver.Result result) {

String url = result.getUri();

Uri uri = "".equals(url) ? Uri.EMPTY : Uri.parse(url);

- mDelegate.setUri(uri, result.isPlayable());

+ mDelegate.deliverResult(uri, result.isPlayable());

}

private String sanitizeUrl(String unsafeUrl) {