google_apis/gcm/engine/connection_factory_impl_unittest.cc - Issue 160703002: [GCM] Track connection failures properly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/connection_factory_impl_unittest.cc

Issue 160703002: [GCM] Track connection failures properly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Self review and add connection success rate Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« google_apis/gcm/engine/connection_factory_impl.cc ('K') | « google_apis/gcm/engine/connection_factory_impl.cc ('k') | google_apis/gcm/engine/fake_connection_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gcm/engine/connection_factory_impl_unittest.cc

diff --git a/google_apis/gcm/engine/connection_factory_impl_unittest.cc b/google_apis/gcm/engine/connection_factory_impl_unittest.cc

index 93a76dd5fd4bc4c1d1cee56175f3603f69c63b9a..82c3f18d9877c875b7622135ecd261f639945f9e 100644

--- a/google_apis/gcm/engine/connection_factory_impl_unittest.cc

+++ b/google_apis/gcm/engine/connection_factory_impl_unittest.cc

@@ -351,7 +351,7 @@ TEST_F(ConnectionFactoryImplTest, FailViaSignalReset) {

factory()->Connect();

EXPECT_TRUE(factory()->NextRetryAttempt().is_null());

- factory()->SignalConnectionReset();

+ factory()->SignalConnectionReset(ConnectionFactory::SOCKET_FAILURE);

EXPECT_FALSE(factory()->NextRetryAttempt().is_null());

EXPECT_FALSE(factory()->GetConnectionHandler()->CanSendMessage());

}

@@ -365,13 +365,13 @@ TEST_F(ConnectionFactoryImplTest, IgnoreResetWhileConnecting) {

factory()->Connect();

EXPECT_TRUE(factory()->NextRetryAttempt().is_null());

- factory()->SignalConnectionReset();

+ factory()->SignalConnectionReset(ConnectionFactory::SOCKET_FAILURE);

base::TimeTicks retry_time = factory()->NextRetryAttempt();

EXPECT_FALSE(retry_time.is_null());

const int kNumAttempts = 5;

for (int i = 0; i < kNumAttempts; ++i)

- factory()->SignalConnectionReset();

+ factory()->SignalConnectionReset(ConnectionFactory::SOCKET_FAILURE);

EXPECT_EQ(retry_time, factory()->NextRetryAttempt());

}

@@ -395,7 +395,7 @@ TEST_F(ConnectionFactoryImplTest, SignalResetRestoresBackoff) {

WaitForConnections();

EXPECT_TRUE(factory()->NextRetryAttempt().is_null());

- factory()->SignalConnectionReset();

+ factory()->SignalConnectionReset(ConnectionFactory::SOCKET_FAILURE);

EXPECT_FALSE(factory()->GetConnectionHandler()->CanSendMessage());

EXPECT_NE(retry_time, factory()->NextRetryAttempt());

retry_time = factory()->NextRetryAttempt();

@@ -410,7 +410,7 @@ TEST_F(ConnectionFactoryImplTest, SignalResetRestoresBackoff) {

WaitForConnections();

EXPECT_TRUE(factory()->NextRetryAttempt().is_null());

- factory()->SignalConnectionReset();

+ factory()->SignalConnectionReset(ConnectionFactory::SOCKET_FAILURE);

EXPECT_NE(retry_time, factory()->NextRetryAttempt());

retry_time = factory()->NextRetryAttempt();

EXPECT_FALSE(retry_time.is_null());