Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Side by Side Diff: google_apis/gcm/engine/fake_connection_handler.cc

Issue 160703002: [GCM] Track connection failures properly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review and add connection success rate Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "google_apis/gcm/engine/fake_connection_handler.h" 5 #include "google_apis/gcm/engine/fake_connection_handler.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "google_apis/gcm/base/mcs_util.h" 8 #include "google_apis/gcm/base/mcs_util.h"
9 #include "net/socket/stream_socket.h" 9 #include "net/socket/stream_socket.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 22 matching lines...) Expand all
33 fail_login_(false), 33 fail_login_(false),
34 fail_send_(false), 34 fail_send_(false),
35 initialized_(false) { 35 initialized_(false) {
36 } 36 }
37 37
38 FakeConnectionHandler::~FakeConnectionHandler() { 38 FakeConnectionHandler::~FakeConnectionHandler() {
39 } 39 }
40 40
41 void FakeConnectionHandler::Init(const mcs_proto::LoginRequest& login_request, 41 void FakeConnectionHandler::Init(const mcs_proto::LoginRequest& login_request,
42 net::StreamSocket* socket) { 42 net::StreamSocket* socket) {
43 ASSERT_GE(expected_outgoing_messages_.size(), 1U);
43 EXPECT_EQ(expected_outgoing_messages_.front().SerializeAsString(), 44 EXPECT_EQ(expected_outgoing_messages_.front().SerializeAsString(),
44 login_request.SerializeAsString()); 45 login_request.SerializeAsString());
45 expected_outgoing_messages_.pop_front(); 46 expected_outgoing_messages_.pop_front();
46 DVLOG(1) << "Received init call."; 47 DVLOG(1) << "Received init call.";
47 read_callback_.Run(BuildLoginResponse(fail_login_)); 48 read_callback_.Run(BuildLoginResponse(fail_login_));
48 initialized_ = !fail_login_; 49 initialized_ = !fail_login_;
49 } 50 }
50 51
51 void FakeConnectionHandler::Reset() { 52 void FakeConnectionHandler::Reset() {
52 initialized_ = false; 53 initialized_ = false;
(...skipping 28 matching lines...) Expand all
81 82
82 bool FakeConnectionHandler::AllOutgoingMessagesReceived() const { 83 bool FakeConnectionHandler::AllOutgoingMessagesReceived() const {
83 return expected_outgoing_messages_.empty(); 84 return expected_outgoing_messages_.empty();
84 } 85 }
85 86
86 void FakeConnectionHandler::ReceiveMessage(const MCSMessage& message) { 87 void FakeConnectionHandler::ReceiveMessage(const MCSMessage& message) {
87 read_callback_.Run(message.CloneProtobuf()); 88 read_callback_.Run(message.CloneProtobuf());
88 } 89 }
89 90
90 } // namespace gcm 91 } // namespace gcm
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698