Chromium Code Reviews
Help | Chromium Project | Sign in
(13)

Issue 1607004: Add the proxy information to the new net internals page. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by eroman
Modified:
2 years, 10 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews_chromium.org, arv, ben+cc_chromium.org
Visibility:
Public.

Description

Add the proxy information to the new net internals page.
BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43636

Patch Set 1 #

Total comments: 1

Patch Set 2 : Pass the bad proxies as a list, rather than flat HTML #

Patch Set 3 : Max the URL work in presence of '#' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+404 lines, -44 lines) Lint Patch
M chrome/browser/dom_ui/net_internals_ui.cc View 1 2 17 chunks +143 lines, -16 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/index.html View 1 2 chunks +21 lines, -1 line 0 comments 0 errors Download
M chrome/browser/resources/net_internals/main.css View 1 chunk +11 lines, -1 line 0 comments 0 errors Download
M chrome/browser/resources/net_internals/main.js View 1 3 chunks +165 lines, -25 lines 0 comments 0 errors Download
A chrome/browser/resources/net_internals/proxyview.js View 1 1 chunk +62 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/requestsview.js View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 3
eroman
Porting more of about:net-internals to the javascript frontend.
4 years ago #1
eroman
Updated to address a TODO.
4 years ago #2
Mike Belshe
4 years ago #3
lgtm

http://codereview.chromium.org/1607004/diff/1/7
File chrome/browser/dom_ui/net_internals_ui.cc (right):

http://codereview.chromium.org/1607004/diff/1/7#newcode336
chrome/browser/dom_ui/net_internals_ui.cc:336:
CallJavascriptFunction(L"g_browser.receivedLogEventTypeConstants", dict);
nit:  Do you think these function names should be made into constants?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434