Issue 16070003: Move immersive fullscreen check into ImmersiveFullscreenConfiguration.

Issue 16070003: Move immersive fullscreen check into ImmersiveFullscreenConfiguration. (Closed)

Created:
7 years, 7 months ago by tfarina

Modified:
7 years, 6 months ago

Reviewers:
James Cook, Ben Goodger (Google), commit-bot: I haz the power

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move immersive fullscreen check into ImmersiveFullscreenConfiguration. BUG=239168, 125846 R=jamescook@chromium.org,ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202783

Patch Set 3 : move EnableImmersiveFullscreenForTest() as well #

Patch Set 4 : rm the DEPS again #

Patch Set 5 : sync+rebase #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -53 lines)			Patch
D	chrome/browser/ui/ash/DEPS	View	1 3	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/immersive_fullscreen_configuration.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/immersive_fullscreen_configuration.cc	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc	View	1 2	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/immersive_mode_controller.h	View	1 2	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc	View	1 2	1 chunk	+0 lines, -23 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

tfarina

Hi James, could you review this to me? Ben c/b/ui Thanks,

7 years, 7 months ago (2013-05-26 15:22:24 UTC) #1

James Cook

LGTM, but please move EnableImmersiveFullscreenForTest. https://codereview.chromium.org/16070003/diff/2001/chrome/browser/ui/immersive_fullscreen_configuration.cc File chrome/browser/ui/immersive_fullscreen_configuration.cc (right): https://codereview.chromium.org/16070003/diff/2001/chrome/browser/ui/immersive_fullscreen_configuration.cc#newcode20 chrome/browser/ui/immersive_fullscreen_configuration.cc:20: // change the enable ...

7 years, 7 months ago (2013-05-27 12:00:20 UTC) #2

tfarina

https://codereview.chromium.org/16070003/diff/2001/chrome/browser/ui/immersive_fullscreen_configuration.cc File chrome/browser/ui/immersive_fullscreen_configuration.cc (right): https://codereview.chromium.org/16070003/diff/2001/chrome/browser/ui/immersive_fullscreen_configuration.cc#newcode20 chrome/browser/ui/immersive_fullscreen_configuration.cc:20: // change the enable function below and BrowserTest FullscreenBookmarkBar ...

7 years, 6 months ago (2013-05-29 02:03:52 UTC) #4