Implement Windows GPO support for "dlpref" in component updater.

chrome/browser/component_updater/chrome_component_updater_configurator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/chrome_component_updater_configurator.h"
 
 #include <string>
 #include <vector>
 
+#include "base/strings/sys_string_conversions.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/version.h"
+#if defined(OS_WIN)
+#include "base/win/win_util.h"
+#endif
 #include "chrome/browser/component_updater/component_patcher_operation_out_of_process.h"
 #include "chrome/browser/update_client/chrome_update_query_params_delegate.h"
 #include "chrome/common/channel_info.h"
+#if defined(OS_WIN)
+#include "chrome/installer/util/google_update_settings.h"
+#endif
 #include "components/component_updater/configurator_impl.h"
 #include "content/public/browser/browser_thread.h"
 
 namespace component_updater {
 
 namespace {
 
 class ChromeConfigurator : public update_client::Configurator {
  public:
   ChromeConfigurator(const base::CommandLine* cmdline,
                      net::URLRequestContextGetter* url_request_getter);
 
   // update_client::Configurator overrides.
   int InitialDelay() const override;
   int NextCheckDelay() const override;
   int StepDelay() const override;
   int OnDemandDelay() const override;
   int UpdateDelay() const override;
   std::vector<GURL> UpdateUrl() const override;
   std::vector<GURL> PingUrl() const override;
   base::Version GetBrowserVersion() const override;
   std::string GetChannel() const override;
   std::string GetLang() const override;
   std::string GetOSLongName() const override;
   std::string ExtraRequestParams() const override;
+  std::string GetDownloadPreference() const override;
   net::URLRequestContextGetter* RequestContext() const override;
   scoped_refptr<update_client::OutOfProcessPatcher> CreateOutOfProcessPatcher()
       const override;
   bool DeltasEnabled() const override;
   bool UseBackgroundDownloader() const override;
   scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner()
       const override;
 
  private:
   friend class base::RefCountedThreadSafe<ChromeConfigurator>;
@@ skipping 49 matching lines @@
 }
 
 std::string ChromeConfigurator::GetOSLongName() const {
   return configurator_impl_.GetOSLongName();
 }
 
 std::string ChromeConfigurator::ExtraRequestParams() const {
   return configurator_impl_.ExtraRequestParams();
 }
 
+std::string ChromeConfigurator::GetDownloadPreference() const {
+#if defined(OS_WIN)
+  // This group policy is supported only on Windows and only for computers
+  // which are joined to a Windows domain.
+  return base::win::IsEnrolledToDomain()
+             ? base::SysWideToUTF8(
+                   GoogleUpdateSettings::GetDownloadPreference())
+             : std::string("");
+#else
+  return std::string("");

[droger, 2016/01/22 10:32:15]

Why not
return configurator_impl_.GetDownloadPreference();

or at least
  return std::string();

+#endif
+}
+
 net::URLRequestContextGetter* ChromeConfigurator::RequestContext() const {
   return configurator_impl_.RequestContext();
 }
 
 scoped_refptr<update_client::OutOfProcessPatcher>
 ChromeConfigurator::CreateOutOfProcessPatcher() const {
   return make_scoped_refptr(new ChromeOutOfProcessPatcher);
 }
 
 bool ChromeConfigurator::DeltasEnabled() const {
@@ skipping 19 matching lines @@
 }  // namespace
 
 scoped_refptr<update_client::Configurator>
 MakeChromeComponentUpdaterConfigurator(
     const base::CommandLine* cmdline,
     net::URLRequestContextGetter* context_getter) {
   return new ChromeConfigurator(cmdline, context_getter);
 }
 
 }  // namespace component_updater