Adds UMA for counting component event page wakeups.

Adds UMA for counting component event page wakeups.

This adds a histogram for counting events that wake up component event pages.  This will be especially helpful for optimizing the behavior of the Media Router which (I believe) is the only component event page for certain network events (chrome.dial, chrome.mdns, chrome.cast.*).

Also adds a unit test case for EventRouter::ReportEvent.

BUG=563883
Committed: https://crrev.com/36f10145aa44e80260fa312d5771940d9289533f
Cr-Commit-Position: refs/heads/master@{#370763}

[imcheng, 2016-01-20 18:28:21]

imcheng@chromium.org changed reviewers:
+ imcheng@chromium.org

[imcheng, 2016-01-20 18:28:21]

https://codereview.chromium.org/1606943005/diff/1/extensions/browser/event_ro...
File extensions/browser/event_router_unittest.cc (right):

https://codereview.chromium.org/1606943005/diff/1/extensions/browser/event_ro...
extensions/browser/event_router_unittest.cc:94: return manifest;
It should compile if you changed this to:

std::move(manifest);

[mark a. foltz, 2016-01-20 21:56:21]

Description was changed from

==========
Adds UMA for counting component event page wakeups.

BUG=563883
==========

to

==========
Adds UMA for counting component event page wakeups.

This adds a histogram for counting events that wake up component event pages. 
This will be especially helpful for optimizing the behavior of the Media Router
which (I believe) is the only component event page for certain network events
(chrome.dial, chrome.mdns, chrome.cast.*).

Also adds a unit test case for EventRouter::ReportEvent.

BUG=563883
==========

[mark a. foltz, 2016-01-20 21:56:21]

mfoltz@chromium.org changed reviewers:
+ benwells@chromium.org, isherman@chromium.org

[mark a. foltz, 2016-01-20 21:56:58]

+isherman for histograms.xml
+benwells for everything else

PTAL

[mark a. foltz, 2016-01-20 21:58:07]

https://codereview.chromium.org/1606943005/diff/1/extensions/browser/event_ro...
File extensions/browser/event_router_unittest.cc (right):

https://codereview.chromium.org/1606943005/diff/1/extensions/browser/event_ro...
extensions/browser/event_router_unittest.cc:94: return manifest;
On 2016/01/20 at 18:28:21, imcheng1 wrote:
> It should compile if you changed this to:
> 
> std::move(manifest);

Thanks!  That was the fix.  It isn't clear to me yet when move-ing is done
implicitly and the error message if you don't is pretty obscure :)

[Ilya Sherman, 2016-01-20 23:01:11]

histograms lgtm

[benwells, 2016-01-20 23:23:36]

lgtm with a nit

https://codereview.chromium.org/1606943005/diff/20001/extensions/browser/even...
File extensions/browser/event_router_unittest.cc (right):

https://codereview.chromium.org/1606943005/diff/20001/extensions/browser/even...
extensions/browser/event_router_unittest.cc:263: ExpectHistogramCounts(5, 1, 2,
1, 0, 1);
Nit: Seems like having ExpectHistogramCounts(4, 1, 2, 0, 0, 1) (or whatever it
should be) between the two ReportEvents would make the difference between
enqueue being true and false explicitly tested. Same goes for the next block.

[mark a. foltz, 2016-01-21 18:32:43]

On 2016/01/20 at 23:23:36, benwells wrote:
> lgtm with a nit
> 
>
https://codereview.chromium.org/1606943005/diff/20001/extensions/browser/even...
> File extensions/browser/event_router_unittest.cc (right):
> 
>
https://codereview.chromium.org/1606943005/diff/20001/extensions/browser/even...
> extensions/browser/event_router_unittest.cc:263: ExpectHistogramCounts(5, 1,
2, 1, 0, 1);
> Nit: Seems like having ExpectHistogramCounts(4, 1, 2, 0, 0, 1) (or whatever it
should be) between the two ReportEvents would make the difference between
enqueue being true and false explicitly tested. Same goes for the next block.

Done.

[mark a. foltz, 2016-01-21 18:32:50]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2016-01-21 18:32:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1606943005/#ps40001
(title: "Adds histogram expectations, and some comments.")

[commit-bot: I haz the power, 2016-01-21 18:34:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1606943005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1606943005/40001

[commit-bot: I haz the power, 2016-01-21 20:01:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-21 20:02:59]

Description was changed from

==========
Adds UMA for counting component event page wakeups.

This adds a histogram for counting events that wake up component event pages. 
This will be especially helpful for optimizing the behavior of the Media Router
which (I believe) is the only component event page for certain network events
(chrome.dial, chrome.mdns, chrome.cast.*).

Also adds a unit test case for EventRouter::ReportEvent.

BUG=563883
==========

to

==========
Adds UMA for counting component event page wakeups.

This adds a histogram for counting events that wake up component event pages. 
This will be especially helpful for optimizing the behavior of the Media Router
which (I believe) is the only component event page for certain network events
(chrome.dial, chrome.mdns, chrome.cast.*).

Also adds a unit test case for EventRouter::ReportEvent.

BUG=563883

Committed: https://crrev.com/36f10145aa44e80260fa312d5771940d9289533f
Cr-Commit-Position: refs/heads/master@{#370763}
==========

[commit-bot: I haz the power, 2016-01-21 20:03:00]

Patchset 3 (id:??) landed as
https://crrev.com/36f10145aa44e80260fa312d5771940d9289533f
Cr-Commit-Position: refs/heads/master@{#370763}