Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: tools/android/loading/request_track.py

Issue 1606903002: tools/android/loading: Archive tracks in LoadingTrace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/android/loading/request_track.py
diff --git a/tools/android/loading/request_track.py b/tools/android/loading/request_track.py
index 08e15880530dcf4c341c5e84f73385a3896b4e03..7130965be74e5c3e4d71a46c6268bfda681fed77 100644
--- a/tools/android/loading/request_track.py
+++ b/tools/android/loading/request_track.py
@@ -230,7 +230,12 @@ class RequestTrack(devtools_monitor.Track):
# network stack.
('requestHeaders', 'request_headers'),
('headers', 'response_headers')))
- timing_dict = response['timing'] if r.protocol != 'data' else {}
+ # data URLs don't have a timing dict.
+ timing_dict = {}
+ if r.protocol != 'data':
+ timing_dict = response['timing']
+ else:
+ timing_dict = {'requestTime': r.timestamp}
r.timing = _TimingFromDict(timing_dict)
self._requests_in_flight[request_id] = (r, RequestTrack._STATUS_RESPONSE)
@@ -291,7 +296,8 @@ def _TimingFromDict(timing_dict):
def _CopyFromDictToObject(d, o, key_attrs):
for (key, attr) in key_attrs:
- setattr(o, attr, d[key])
+ if key in d:
+ setattr(o, attr, d[key])
if __name__ == '__main__':

Powered by Google App Engine
This is Rietveld 408576698