Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 16069010: extend SkBenchmark to allow a bench to return a durationScale, which allows it to perform fewer act… (Closed)

Created:
7 years, 6 months ago by reed1
Modified:
7 years, 6 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

extend SkBenchmark to allow a bench to return a durationScale, which allows it to perform fewer actual interations, but report a scale factor to account for that. Thus a very slow bench can be compared head-to-head with a faster one, w/o actually forcing the tool to run for the full duration of the slower test. Extend BitmapBench to time bicubic filtering, and use this durationScale for it. Extend SkBenchmark to have setBitmapFlags(or, clear), allowing it to request a set of paint flags to be cleared, and set to be set. BUG= R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9315

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -52 lines) Patch
M bench/BenchTimer.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M bench/BenchTimer.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M bench/BitmapBench.cpp View 1 2 10 chunks +75 lines, -44 lines 0 comments Download
M bench/SkBenchmark.h View 1 2 3 chunks +24 lines, -0 lines 0 comments Download
M bench/SkBenchmark.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M bench/benchmain.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
reed1
7 years, 6 months ago (2013-05-28 21:46:51 UTC) #1
robertphillips
lgtm + some questions & suggestions https://codereview.chromium.org/16069010/diff/2001/bench/BitmapBench.cpp File bench/BitmapBench.cpp (right): https://codereview.chromium.org/16069010/diff/2001/bench/BitmapBench.cpp#newcode149 bench/BitmapBench.cpp:149: int count = ...
7 years, 6 months ago (2013-05-29 13:14:17 UTC) #2
reed1
https://codereview.chromium.org/16069010/diff/2001/bench/BitmapBench.cpp File bench/BitmapBench.cpp (right): https://codereview.chromium.org/16069010/diff/2001/bench/BitmapBench.cpp#newcode149 bench/BitmapBench.cpp:149: int count = N; On 2013/05/29 13:14:17, robertphillips wrote: ...
7 years, 6 months ago (2013-05-29 15:02:30 UTC) #3
reed1
7 years, 6 months ago (2013-05-29 15:40:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r9315 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698