Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1606783002:
[builtins] Migrate Object.getOwnPropertyDescriptor to C++. (Closed)
|
Created:
4 years, 11 months ago by Benedikt Meurer Modified:
4 years, 10 months ago Reviewers:
Yang CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[builtins] Migrate Object.getOwnPropertyDescriptor to C++.
The implementation of Object.getOwnPropertyDescriptor always called into
C++ anyway, so there's no need to have this JavaScript wrapper around at
all.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_rel_ng
R=yangguo@chromium.org
Committed: https://crrev.com/3fdd37b028f4711d0f6dcb038f575ce08ef0cfa3
Cr-Commit-Position: refs/heads/master@{#33379}
Committed: https://crrev.com/da5f4a6ad895586939799b92bd6153517d35bf06
Cr-Commit-Position: refs/heads/master@{#33773}
Patch Set 1 #Patch Set 2 : REBASE #
Messages
Total messages: 34 (17 generated)
Hey Yang, More v8natives cleanup. Please take a look. Thanks, Benedikt
On 2016/01/19 06:30:36, Benedikt Meurer wrote: > Hey Yang, > > More v8natives cleanup. > Please take a look. > > Thanks, > Benedikt lgtm.
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606783002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [builtins] Migrate Object.getOwnPropertyDescriptor to C++. The implementation of Object.getOwnPropertyDescriptor always called into C++ anyway, so there's no need to have this JavaScript wrapper around at all. R=yangguo@chromium.org ========== to ========== [builtins] Migrate Object.getOwnPropertyDescriptor to C++. The implementation of Object.getOwnPropertyDescriptor always called into C++ anyway, so there's no need to have this JavaScript wrapper around at all. R=yangguo@chromium.org Committed: https://crrev.com/3fdd37b028f4711d0f6dcb038f575ce08ef0cfa3 Cr-Commit-Position: refs/heads/master@{#33379} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3fdd37b028f4711d0f6dcb038f575ce08ef0cfa3 Cr-Commit-Position: refs/heads/master@{#33379}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1609023003/ by hablich@chromium.org. The reason for reverting is: Breaks roll: https://codereview.chromium.org/1603953002/.
Message was sent while issue was closed.
Description was changed from ========== [builtins] Migrate Object.getOwnPropertyDescriptor to C++. The implementation of Object.getOwnPropertyDescriptor always called into C++ anyway, so there's no need to have this JavaScript wrapper around at all. R=yangguo@chromium.org Committed: https://crrev.com/3fdd37b028f4711d0f6dcb038f575ce08ef0cfa3 Cr-Commit-Position: refs/heads/master@{#33379} ========== to ========== [builtins] Migrate Object.getOwnPropertyDescriptor to C++. The implementation of Object.getOwnPropertyDescriptor always called into C++ anyway, so there's no need to have this JavaScript wrapper around at all. R=yangguo@chromium.org Committed: https://crrev.com/3fdd37b028f4711d0f6dcb038f575ce08ef0cfa3 Cr-Commit-Position: refs/heads/master@{#33379} ==========
Description was changed from ========== [builtins] Migrate Object.getOwnPropertyDescriptor to C++. The implementation of Object.getOwnPropertyDescriptor always called into C++ anyway, so there's no need to have this JavaScript wrapper around at all. R=yangguo@chromium.org Committed: https://crrev.com/3fdd37b028f4711d0f6dcb038f575ce08ef0cfa3 Cr-Commit-Position: refs/heads/master@{#33379} ========== to ========== [builtins] Migrate Object.getOwnPropertyDescriptor to C++. The implementation of Object.getOwnPropertyDescriptor always called into C++ anyway, so there's no need to have this JavaScript wrapper around at all. CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_rel_ng R=yangguo@chromium.org Committed: https://crrev.com/3fdd37b028f4711d0f6dcb038f575ce08ef0cfa3 Cr-Commit-Position: refs/heads/master@{#33379} ==========
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606783002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606783002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9985)
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org Link to the patchset: https://codereview.chromium.org/1606783002/#ps40001 (title: "REBASE")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606783002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606783002/40001
The CQ bit was unchecked by bmeurer@chromium.org
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606783002/40001
Message was sent while issue was closed.
Description was changed from ========== [builtins] Migrate Object.getOwnPropertyDescriptor to C++. The implementation of Object.getOwnPropertyDescriptor always called into C++ anyway, so there's no need to have this JavaScript wrapper around at all. CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_rel_ng R=yangguo@chromium.org Committed: https://crrev.com/3fdd37b028f4711d0f6dcb038f575ce08ef0cfa3 Cr-Commit-Position: refs/heads/master@{#33379} ========== to ========== [builtins] Migrate Object.getOwnPropertyDescriptor to C++. The implementation of Object.getOwnPropertyDescriptor always called into C++ anyway, so there's no need to have this JavaScript wrapper around at all. CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_rel_ng R=yangguo@chromium.org Committed: https://crrev.com/3fdd37b028f4711d0f6dcb038f575ce08ef0cfa3 Cr-Commit-Position: refs/heads/master@{#33379} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [builtins] Migrate Object.getOwnPropertyDescriptor to C++. The implementation of Object.getOwnPropertyDescriptor always called into C++ anyway, so there's no need to have this JavaScript wrapper around at all. CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_rel_ng R=yangguo@chromium.org Committed: https://crrev.com/3fdd37b028f4711d0f6dcb038f575ce08ef0cfa3 Cr-Commit-Position: refs/heads/master@{#33379} ========== to ========== [builtins] Migrate Object.getOwnPropertyDescriptor to C++. The implementation of Object.getOwnPropertyDescriptor always called into C++ anyway, so there's no need to have this JavaScript wrapper around at all. CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_rel_ng R=yangguo@chromium.org Committed: https://crrev.com/3fdd37b028f4711d0f6dcb038f575ce08ef0cfa3 Cr-Commit-Position: refs/heads/master@{#33379} Committed: https://crrev.com/da5f4a6ad895586939799b92bd6153517d35bf06 Cr-Commit-Position: refs/heads/master@{#33773} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/da5f4a6ad895586939799b92bd6153517d35bf06 Cr-Commit-Position: refs/heads/master@{#33773} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
