Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: tools/gn/target_generator.h

Issue 1606553002: Add support for Mac/iOS application bundles to GN tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unit tests & support for bundle_data_filter Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/target_generator.h
diff --git a/tools/gn/target_generator.h b/tools/gn/target_generator.h
index 4fa51f622ab40ca672bf5a481fc8b0dc41ed95be..9bbb4d23deb1d5909d8b07c42a83a550a6034542 100644
--- a/tools/gn/target_generator.h
+++ b/tools/gn/target_generator.h
@@ -53,8 +53,9 @@ class TargetGenerator {
bool FillConfigs();
bool FillOutputs(bool allow_substitutions);
bool FillCheckIncludes();
+ bool FillBundleDataFilter();
- // Rrturns true if the given pattern will expand to a file in the output
+ // Returns true if the given pattern will expand to a file in the output
// directory. If not, returns false and sets the error, blaming the given
// Value.
bool EnsureSubstitutionIsInOutputDir(const SubstitutionPattern& pattern,
@@ -68,6 +69,7 @@ class TargetGenerator {
private:
bool FillDependentConfigs(); // Includes all types of dependent configs.
bool FillData();
+ bool FillBundleData();
bool FillDependencies(); // Includes data dependencies.
bool FillTestonly();
bool FillAssertNoDeps();

Powered by Google App Engine
This is Rietveld 408576698