Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: tools/gn/command_desc.cc

Issue 1606553002: Add support for Mac/iOS application bundles to GN tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unit tests & support for bundle_data_filter Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/command_desc.cc
diff --git a/tools/gn/command_desc.cc b/tools/gn/command_desc.cc
index 27b1d01d45f1ecdb8449599814cef251afbbad7b..3c851ae441313837da7150fa6ad1fa14a0741678 100644
--- a/tools/gn/command_desc.cc
+++ b/tools/gn/command_desc.cc
@@ -680,11 +680,11 @@ int RunDesc(const std::vector<std::string>& args) {
// Display summary.
// Display this only applicable to binary targets.
- bool is_binary_output =
- target->output_type() != Target::GROUP &&
- target->output_type() != Target::COPY_FILES &&
- target->output_type() != Target::ACTION &&
- target->output_type() != Target::ACTION_FOREACH;
+ bool is_binary_output = target->output_type() != Target::GROUP &&
+ target->output_type() != Target::COPY_FILES &&
+ target->output_type() != Target::COPY_BUNDLE_DATA &&
+ target->output_type() != Target::ACTION &&
+ target->output_type() != Target::ACTION_FOREACH;
// Generally we only want to display toolchains on labels when the toolchain
// is different than the default one for this target (which we always print
@@ -738,7 +738,8 @@ int RunDesc(const std::vector<std::string>& args) {
if (target->output_type() == Target::ACTION ||
target->output_type() == Target::ACTION_FOREACH ||
- target->output_type() == Target::COPY_FILES) {
+ target->output_type() == Target::COPY_FILES ||
+ target->output_type() == Target::COPY_BUNDLE_DATA) {
PrintOutputs(target, true);
}

Powered by Google App Engine
This is Rietveld 408576698