Add support for Mac/iOS application bundles to GN tool.

tools/gn/target.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef TOOLS_GN_TARGET_H_
 #define TOOLS_GN_TARGET_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 22 matching lines @@
  public:
   enum OutputType {
     UNKNOWN,
     GROUP,
     EXECUTABLE,
     SHARED_LIBRARY,
     LOADABLE_MODULE,
     STATIC_LIBRARY,
     SOURCE_SET,
     COPY_FILES,
+    COPY_BUNDLE_DATA,
     ACTION,
     ACTION_FOREACH,
   };
 
   enum DepsIterationType {
     DEPS_ALL,  // Iterates through all public, private, and data deps.
     DEPS_LINKED,  // Iterates through all non-data dependencies.
   };
 
   typedef std::vector<SourceFile> FileList;
@@ skipping 74 matching lines @@
   // directories or files. They do not need to exist, these are just passed as
   // runtime dependencies to external test systems as necessary.
   const std::vector<std::string>& data() const { return data_; }
   std::vector<std::string>& data() { return data_; }
 
   // Returns true if targets depending on this one should have an order
   // dependency.
   bool hard_dep() const {
     return output_type_ == ACTION ||
            output_type_ == ACTION_FOREACH ||
-           output_type_ == COPY_FILES;
+           output_type_ == COPY_FILES ||
+           output_type_ == COPY_BUNDLE_DATA;

[brettw, 2016/01/20 22:23:17]

Are you sure you need this?

The COPY_FILES rule is here because it may copy a header file that is required
to compile a source file. Unless the copy rule is executed first, compilation
may fail.

But I don't think compilation steps will take bundle data as input. I believe
only an script will, and an action will always require its inputs to be
up-to-date before doing anything.

The reason not to do this is that the COPY_BUNDLE_DATA step will require that
all dependencies be up-to-date, and marking it as hard requires it be done
before any dependencies are compiled, so this will serialize a significant part
of the build.

If not having this gives a problem, we should understand exactly what the issue
is, maybe there's a less destructive way to express what we need.

[sdefresne, 2016/01/21 22:00:56]

Good point. Removed.

   }
 
   // Returns the iterator range which can be used in range-based for loops
   // to iterate over multiple types of deps in one loop:
   //   for (const auto& pair : target->GetDeps(Target::DEPS_ALL)) ...
   DepsIteratorRange GetDeps(DepsIterationType type) const;
 
   // Linked private dependencies.
   const LabelTargetVector& private_deps() const { return private_deps_; }
   LabelTargetVector& private_deps() { return private_deps_; }
@@ skipping 172 matching lines @@
 
   // Output files. Empty until the target is resolved.
   std::vector<OutputFile> computed_outputs_;
   OutputFile link_output_file_;
   OutputFile dependency_output_file_;
 
   DISALLOW_COPY_AND_ASSIGN(Target);
 };
 
 #endif  // TOOLS_GN_TARGET_H_