Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1606543005: Update Stream.listen doc and use ?? in some places. (Closed)

Created:
4 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 11 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -30 lines) Patch
M CHANGELOG.md View 2 chunks +6 lines, -2 lines 0 comments Download
M sdk/lib/async/future.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/stream.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/async/zone.dart View 1 chunk +15 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
A collection of small tweaks.
4 years, 11 months ago (2016-01-20 12:17:31 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1606543005/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/1606543005/diff/1/sdk/lib/async/stream.dart#newcode329 sdk/lib/async/stream.dart:329: * and will be passed to the current ...
4 years, 11 months ago (2016-01-20 13:34:57 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/1606543005/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/1606543005/diff/1/sdk/lib/async/stream.dart#newcode329 sdk/lib/async/stream.dart:329: * and will be passed to the current [Zone]'s ...
4 years, 11 months ago (2016-01-21 07:29:08 UTC) #4
Lasse Reichstein Nielsen
4 years, 11 months ago (2016-01-21 11:58:29 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
3990be61d93b48c80f98e22fbb6bc301d804fbb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698