Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 1606493002: [interpreter] Add field for handler table to bytecode array. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Add field for handler table to bytecode array. This adds a handler table field to the header of our BytecodeArray objects. The field will eventually hold a range-based handler table similar to full-codegen code, to support exception handlong within interpreted code. R=oth@chromium.org BUG=v8:4674 LOG=n Committed: https://crrev.com/e26aa58b1af9f112f0ee315edab8375f8f3ea5f3 Cr-Commit-Position: refs/heads/master@{#33373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 11 months ago (2016-01-18 13:47:38 UTC) #4
oth
lgtm.
4 years, 11 months ago (2016-01-18 16:53:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606493002/1
4 years, 11 months ago (2016-01-18 17:07:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 17:20:43 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 17:21:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e26aa58b1af9f112f0ee315edab8375f8f3ea5f3
Cr-Commit-Position: refs/heads/master@{#33373}

Powered by Google App Engine
This is Rietveld 408576698