Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1606373002: Fix ActivityAssigner StrictMode Violation (Closed)

Created:
4 years, 11 months ago by hartmanng
Modified:
4 years, 11 months ago
CC:
Peter Wen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ActivityAssigner StrictMode Violation. This should fix (and unwhitelist) the strict mode violation caused by reading shared prefs. I'm using the same strategy as in https://codereview.chromium.org/1464313010/ previously, to pre-load the shared prefs to warm them up so that by the time we need to read them, they're already in memory. BUG=562189 Committed: https://crrev.com/66f15c1e65b5d5a30b68022a4a7edf005cd6630f Cr-Commit-Position: refs/heads/master@{#371007}

Patch Set 1 #

Patch Set 2 : undo whitelist #

Patch Set 3 : warm prefs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -34 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ActivityAssigner.java View 1 2 4 chunks +10 lines, -34 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hartmanng
David, please take a look.
4 years, 11 months ago (2016-01-20 20:29:24 UTC) #4
David Trainor- moved to gerrit
lgtm
4 years, 11 months ago (2016-01-22 17:37:27 UTC) #5
hartmanng
On 2016/01/22 17:37:27, David Trainor wrote: > lgtm Thanks!
4 years, 11 months ago (2016-01-22 18:30:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606373002/40001
4 years, 11 months ago (2016-01-22 18:33:30 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-22 19:18:23 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 19:19:49 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/66f15c1e65b5d5a30b68022a4a7edf005cd6630f
Cr-Commit-Position: refs/heads/master@{#371007}

Powered by Google App Engine
This is Rietveld 408576698