Implemented SkFontHost::CreateTypefaceFromStream() function. This change is n...

Implemented SkFontHost::CreateTypefaceFromStream() function. This change is necessary in order to support @font-face on Linux.

Changes on WebCore side: https://bugs.webkit.org/show_bug.cgi?id=28015

BUG=18490
TEST=please see the bug descripion.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22724

[Yusuke Sato, 2009-08-05 09:21:54]

Adam, can you review this?

[agl, 2009-08-05 17:23:39]

http://codereview.chromium.org/160635/diff/1/2
File skia/ext/SkFontHost_fontconfig.cpp (right):

http://codereview.chromium.org/160635/diff/1/2#newcode182
Line 182: if (++global_next_remote_font_id >= kRemoteFontMask)
Should not |global_next_remote_font_id| be protected by the mutex too?

[Yusuke Sato, 2009-08-06 06:10:02]

http://codereview.chromium.org/160635/diff/1/2
File skia/ext/SkFontHost_fontconfig.cpp (right):

http://codereview.chromium.org/160635/diff/1/2#newcode182
Line 182: if (++global_next_remote_font_id >= kRemoteFontMask)
On 2009/08/05 17:23:39, agl wrote:
> Should not |global_next_remote_font_id| be protected by the mutex too?

Fixed, thanks.

[Yusuke Sato, 2009-08-06 08:07:22]

Adam, could you review WebCore part as well?
https://bugs.webkit.org/show_bug.cgi?id=28015

Thanks,
Yusuke

[Yusuke Sato, 2009-08-07 06:04:26]

WebKit part has been landed. Is it ok to land this CL as well? The WebKit patch
can be compiled without this patch, though.

Thanks,
Yusuke

[Yusuke Sato, 2009-08-07 06:25:52]

Thanks, submitted.

On Fri, Aug 7, 2009 at 3:14 PM, Adam Langley <agl@chromium.org> wrote:
> Land at will.
>
>
> AGL