Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 160635: Implemented SkFontHost::CreateTypefaceFromStream() function. This change is n... (Closed)

Created:
11 years, 4 months ago by Yusuke Sato
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Implemented SkFontHost::CreateTypefaceFromStream() function. This change is necessary in order to support @font-face on Linux. Changes on WebCore side: https://bugs.webkit.org/show_bug.cgi?id=28015 BUG=18490 TEST=please see the bug descripion. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22724

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -4 lines) Patch
M skia/ext/SkFontHost_fontconfig.cpp View 1 5 chunks +81 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
Adam, can you review this?
11 years, 4 months ago (2009-08-05 09:21:54 UTC) #1
agl
http://codereview.chromium.org/160635/diff/1/2 File skia/ext/SkFontHost_fontconfig.cpp (right): http://codereview.chromium.org/160635/diff/1/2#newcode182 Line 182: if (++global_next_remote_font_id >= kRemoteFontMask) Should not |global_next_remote_font_id| be ...
11 years, 4 months ago (2009-08-05 17:23:39 UTC) #2
Yusuke Sato
http://codereview.chromium.org/160635/diff/1/2 File skia/ext/SkFontHost_fontconfig.cpp (right): http://codereview.chromium.org/160635/diff/1/2#newcode182 Line 182: if (++global_next_remote_font_id >= kRemoteFontMask) On 2009/08/05 17:23:39, agl ...
11 years, 4 months ago (2009-08-06 06:10:02 UTC) #3
Yusuke Sato
Adam, could you review WebCore part as well? https://bugs.webkit.org/show_bug.cgi?id=28015 Thanks, Yusuke
11 years, 4 months ago (2009-08-06 08:07:22 UTC) #4
Yusuke Sato
WebKit part has been landed. Is it ok to land this CL as well? The ...
11 years, 4 months ago (2009-08-07 06:04:26 UTC) #5
Yusuke Sato
11 years, 4 months ago (2009-08-07 06:25:52 UTC) #6
Thanks, submitted.

On Fri, Aug 7, 2009 at 3:14 PM, Adam Langley <agl@chromium.org> wrote:
> Land at will.
>
>
> AGL

Powered by Google App Engine
This is Rietveld 408576698