Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: bench/nanobench.cpp

Issue 1606323002: Make nanobench --outResultsFile only work with Release builds. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/nanobench.cpp
diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp
index 7efd858c5cd5a8a0e761c399a839fa6964526e2b..1ef1bf6fc3c9f10c6fbfe0152f5996a8bc603e8a 100644
--- a/bench/nanobench.cpp
+++ b/bench/nanobench.cpp
@@ -1053,9 +1053,11 @@ int nanobench_main() {
}
SkAutoTDelete<ResultsWriter> log(new ResultsWriter);
+#if defined(SK_RELEASE)
jcgregorio 2016/01/20 17:38:28 Do you also want to emit a warning that the result
mtklein 2016/01/20 17:41:18 Done.
if (!FLAGS_outResultsFile.isEmpty()) {
log.reset(new NanoJSONResultsWriter(FLAGS_outResultsFile[0]));
}
+#endif
if (1 == FLAGS_properties.count() % 2) {
SkDebugf("ERROR: --properties must be passed with an even number of arguments.\n");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698