Make nanobench --outResultsFile only work with Release builds.

Make nanobench --outResultsFile only work with Release builds.

It is very, very misleading to report performance numbers for Debug builds.
This makes it impossible for us to upload them to perf.skia.org.

BUG=skia:4828
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606323002

Committed: https://skia.googlesource.com/skia/+/5352015fa318fc6c25b789cb0a81d2d586d6121f

[mtklein_C, 2016-01-20 16:46:36]

Description was changed from

==========
Make nanobench --outResultsFile only work with Release builds.

It is very, very misleading to report performance numbers for Debug builds.
This makes it impossible for us to upload them to perf.skia.org.

BUG=skia:4828
==========

to

==========
Make nanobench --outResultsFile only work with Release builds.

It is very, very misleading to report performance numbers for Debug builds.
This makes it impossible for us to upload them to perf.skia.org.

BUG=skia:4828
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-01-20 16:47:37]

mtklein@chromium.org changed reviewers:
+ jcgregorio@google.com

[mtklein_C, 2016-01-20 16:47:37]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-01-20 16:47:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1606323002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1606323002/1

[commit-bot: I haz the power, 2016-01-20 16:47:46]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-01-20 22:47 UTC

[jcgregorio, 2016-01-20 17:38:28]

https://codereview.chromium.org/1606323002/diff/1/bench/nanobench.cpp
File bench/nanobench.cpp (right):

https://codereview.chromium.org/1606323002/diff/1/bench/nanobench.cpp#newcode...
bench/nanobench.cpp:1056: #if defined(SK_RELEASE)
Do you also want to emit a warning that the results file isn't being written?

[mtklein, 2016-01-20 17:41:17]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-01-20 17:41:18]

https://codereview.chromium.org/1606323002/diff/1/bench/nanobench.cpp
File bench/nanobench.cpp (right):

https://codereview.chromium.org/1606323002/diff/1/bench/nanobench.cpp#newcode...
bench/nanobench.cpp:1056: #if defined(SK_RELEASE)
On 2016/01/20 17:38:28, jcgregorio wrote:
> Do you also want to emit a warning that the results file isn't being written?

Done.

[mtklein, 2016-01-20 17:42:10]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 17:42:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1606323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1606323002/40001

[jcgregorio, 2016-01-20 17:44:16]

lgtm

[mtklein, 2016-01-20 17:44:29]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2016-01-20 17:44:31]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-01-20 17:44:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1606323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1606323002/40001

[commit-bot: I haz the power, 2016-01-20 17:54:01]

Description was changed from

==========
Make nanobench --outResultsFile only work with Release builds.

It is very, very misleading to report performance numbers for Debug builds.
This makes it impossible for us to upload them to perf.skia.org.

BUG=skia:4828
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make nanobench --outResultsFile only work with Release builds.

It is very, very misleading to report performance numbers for Debug builds.
This makes it impossible for us to upload them to perf.skia.org.

BUG=skia:4828
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/5352015fa318fc6c25b789cb0a81d2d586d6121f
==========

[commit-bot: I haz the power, 2016-01-20 17:54:02]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5352015fa318fc6c25b789cb0a81d2d586d6121f