[Media Router] Add cloud services learn more link to first run flow.

[Media Router] Add cloud services learn more link to first run flow.

Part 5.

This change adds a link target to the "Learn More" text in the cloud services pref section of the first run flow. Also reworked some of the HTML/CSS to make the link clickable.

BUG=560457
Committed: https://crrev.com/513ca7e4b8260b117e16974807ad1dd33ee443fd
Cr-Commit-Position: refs/heads/master@{#371426}

[apacible, 2016-01-20 19:40:54]

Description was changed from

==========
learn more link

BUG=
==========

to

==========
[Media Router] Add cloud services learn more link to first run flow.

This change adds a link target to the "Learn More" text in the cloud services
pref section of the first run flow. Also reworked some of the HTML/CSS to make
the link clickable.

BUG=560457
==========

[apacible, 2016-01-20 19:40:54]

apacible@chromium.org changed reviewers:
+ imcheng@chromium.org

[apacible, 2016-01-20 19:41:24]

PTAL, thanks!

[apacible, 2016-01-20 19:42:25]

Screenshots:

LTR: https://screenshot.googleplex.com/zmpM7zkA4Mm.png
RTL: https://screenshot.googleplex.com/aCN6cWY7XAC.png

[apacible, 2016-01-20 20:04:04]

Description was changed from

==========
[Media Router] Add cloud services learn more link to first run flow.

This change adds a link target to the "Learn More" text in the cloud services
pref section of the first run flow. Also reworked some of the HTML/CSS to make
the link clickable.

BUG=560457
==========

to

==========
[Media Router] Add cloud services learn more link to first run flow.

Part 6.

This change adds a link target to the "Learn More" text in the cloud services
pref section of the first run flow. Also reworked some of the HTML/CSS to make
the link clickable.

BUG=560457
==========

[imcheng, 2016-01-25 19:21:07]

https://codereview.chromium.org/1606303005/diff/1/chrome/browser/resources/me...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
(right):

https://codereview.chromium.org/1606303005/diff/1/chrome/browser/resources/me...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html:19:
if="[[computeShowFirstRunFlow_(showFirstRunFlow, currentView_)]]">
How is the case of user having previously ack'ed the first run flow without
cloud services handled? Seems like everything in this dom-if will just be hidden
in this case?

https://codereview.chromium.org/1606303005/diff/1/chrome/browser/resources/me...
File chrome/browser/resources/media_router/media_router_ui_interface.js (right):

https://codereview.chromium.org/1606303005/diff/1/chrome/browser/resources/me...
chrome/browser/resources/media_router/media_router_ui_interface.js:60: *  
firstRunFlowCloudPrefLearnMoreUrl - url to be opened on "Lean More" from
make this comment consistent with the one in media_router_container.js.

[apacible, 2016-01-25 22:39:43]

https://codereview.chromium.org/1606303005/diff/1/chrome/browser/resources/me...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
(right):

https://codereview.chromium.org/1606303005/diff/1/chrome/browser/resources/me...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html:19:
if="[[computeShowFirstRunFlow_(showFirstRunFlow, currentView_)]]">
On 2016/01/25 19:21:07, imcheng1 wrote:
> How is the case of user having previously ack'ed the first run flow without
> cloud services handled? Seems like everything in this dom-if will just be
hidden
> in this case?

Correct. Currently, everything in this dom-if will be hidden.

I'm working with Jonny to decide how we want to prompt the cloud services
preference for users who have ack'd the first run flow but without cloud
services. Once we've figured that out, I'll rework the templates here if needed.
The cloud pref text may show up elsewhere (e.g. similarly to a non-blocking
Issue).

https://codereview.chromium.org/1606303005/diff/1/chrome/browser/resources/me...
File chrome/browser/resources/media_router/media_router_ui_interface.js (right):

https://codereview.chromium.org/1606303005/diff/1/chrome/browser/resources/me...
chrome/browser/resources/media_router/media_router_ui_interface.js:60: *  
firstRunFlowCloudPrefLearnMoreUrl - url to be opened on "Lean More" from
On 2016/01/25 19:21:07, imcheng1 wrote:
> make this comment consistent with the one in media_router_container.js.

Done.

[imcheng, 2016-01-26 01:23:47]

lgtm

[apacible, 2016-01-26 01:28:32]

Description was changed from

==========
[Media Router] Add cloud services learn more link to first run flow.

Part 6.

This change adds a link target to the "Learn More" text in the cloud services
pref section of the first run flow. Also reworked some of the HTML/CSS to make
the link clickable.

BUG=560457
==========

to

==========
[Media Router] Add cloud services learn more link to first run flow.

Part 5.

This change adds a link target to the "Learn More" text in the cloud services
pref section of the first run flow. Also reworked some of the HTML/CSS to make
the link clickable.

BUG=560457
==========

[apacible, 2016-01-26 01:28:36]

The CQ bit was checked by apacible@chromium.org

[commit-bot: I haz the power, 2016-01-26 01:29:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1606303005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1606303005/40001

[commit-bot: I haz the power, 2016-01-26 02:13:43]

Description was changed from

==========
[Media Router] Add cloud services learn more link to first run flow.

Part 5.

This change adds a link target to the "Learn More" text in the cloud services
pref section of the first run flow. Also reworked some of the HTML/CSS to make
the link clickable.

BUG=560457
==========

to

==========
[Media Router] Add cloud services learn more link to first run flow.

Part 5.

This change adds a link target to the "Learn More" text in the cloud services
pref section of the first run flow. Also reworked some of the HTML/CSS to make
the link clickable.

BUG=560457
==========

[commit-bot: I haz the power, 2016-01-26 02:13:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-26 02:15:57]

Description was changed from

==========
[Media Router] Add cloud services learn more link to first run flow.

Part 5.

This change adds a link target to the "Learn More" text in the cloud services
pref section of the first run flow. Also reworked some of the HTML/CSS to make
the link clickable.

BUG=560457
==========

to

==========
[Media Router] Add cloud services learn more link to first run flow.

Part 5.

This change adds a link target to the "Learn More" text in the cloud services
pref section of the first run flow. Also reworked some of the HTML/CSS to make
the link clickable.

BUG=560457

Committed: https://crrev.com/513ca7e4b8260b117e16974807ad1dd33ee443fd
Cr-Commit-Position: refs/heads/master@{#371426}
==========

[commit-bot: I haz the power, 2016-01-26 02:15:58]

Patchset 3 (id:??) landed as
https://crrev.com/513ca7e4b8260b117e16974807ad1dd33ee443fd
Cr-Commit-Position: refs/heads/master@{#371426}