dumpInspectorProtocolMessages logs objects instead of stringified objects

third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 267 matching lines @@
         var messageId = this.nextMessageId();
         messageObject.id = messageId;
 
         messageObject.method = method;
         if (params)
             messageObject.params = params;
 
         var wrappedCallback = this._wrap(callback, domain, method);
 
         if (InspectorBackendClass.Options.dumpInspectorProtocolMessages)
-            this._dumpProtocolMessage("frontend: " + JSON.stringify(messageObject));
+            this._dumpProtocolMessage("frontend: ", messageObject);
 
         this.sendMessage(messageObject);
         ++this._pendingResponsesCount;
         this._callbacks[messageId] = wrappedCallback;
     },
 
     /**
      * @param {?function(*)} callback
      * @param {string} method
      * @param {string} domain
@@ skipping 18 matching lines @@
     sendMessage: function(messageObject)
     {
         throw "Not implemented";
     },
 
     /**
      * @param {!Object|string} message
      */
     dispatch: function(message)
     {
+        var messageObject = /** @type {!Object} */ ((typeof message === "string") ? JSON.parse(message) : message);
+
         if (InspectorBackendClass.Options.dumpInspectorProtocolMessages)
-            this._dumpProtocolMessage("backend: " + ((typeof message === "string") ? message : JSON.stringify(message)));
-
-        var messageObject = /** @type {!Object} */ ((typeof message === "string") ? JSON.parse(message) : message);
+            this._dumpProtocolMessage("backend: ", messageObject);
 
         if ("id" in messageObject) { // just a response for some request
             var callback = this._callbacks[messageObject.id];
             if (!callback) {
                 InspectorBackendClass.reportProtocolError("Protocol Error: the message with wrong id", messageObject);
                 return;
             }
 
             var processingStartTime;
             if (InspectorBackendClass.Options.dumpInspectorTimeStats)
@@ skipping 57 matching lines @@
     _executeAfterPendingDispatches: function()
     {
         if (!this._pendingResponsesCount) {
             var scripts = this._scripts;
             this._scripts = [];
             for (var id = 0; id < scripts.length; ++id)
                 scripts[id].call(this);
         }
     },
 
-    _dumpProtocolMessage: function(message)
+    _dumpProtocolMessage: function(message, messageObject)
     {
-        console.log(message);
+        console.log.call(console, message, messageObject);
     },
 
     /**
      * @protected
      * @param {string} reason
      */
     connectionClosed: function(reason)
     {
         this._isConnected = false;
         this._runPendingCallbacks();
@@ skipping 207 matching lines @@
 
     /**
      * @param {!Object} messageObject
      * @param {string} methodName
      * @param {function(*)|function(?Protocol.Error, ?Object)} callback
      */
     dispatchResponse: function(messageObject, methodName, callback)
     {
         if (messageObject.error && messageObject.error.code !== InspectorBackendClass._DevToolsErrorCode && messageObject.error.code !== InspectorBackendClass.DevToolsStubErrorCode && !InspectorBackendClass.Options.suppressRequestErrors && !this._suppressErrorLogging) {
             var id = InspectorBackendClass.Options.dumpInspectorProtocolMessages ? " with id = " + messageObject.id : "";
-            console.error("Request " + methodName + id + " failed. " + JSON.stringify(messageObject.error));
+            console.error("Request " + methodName + id + " failed. ", messageObject.error);
         }
 
         var argumentsArray = [];
         argumentsArray[0] = messageObject.error ? messageObject.error.message: null;
 
         if (this._hasErrorData[methodName])
             argumentsArray[1] = messageObject.error ? messageObject.error.data : null;
 
         if (messageObject.result) {
             var paramNames = this._replyArgs[methodName] || [];
@@ skipping 75 matching lines @@
     }
 }
 
 InspectorBackendClass.Options = {
     dumpInspectorTimeStats: false,
     dumpInspectorProtocolMessages: false,
     suppressRequestErrors: false
 }
 
 InspectorBackend = new InspectorBackendClass();