Modify summary codegen so that builder getters return builders.

Modify summary codegen so that builder getters return builders.

This should allow more flexibility in the code that creates summaries,
since it will be possible to things like:

    FooBuilder foo = new FooBuilder(bar: new BarBuilder);
    foo.bar.baz = ...;

(Previously this would have been disallowed because foo.bar would have
returned a `Foo` rather than a `FooBuilder`, and the `Foo` class doesn't
have a setter for `baz`).

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/5e27219e9a2db72145be28edf9f754e25c6d0e3b

[Paul Berry, 2016-01-20 16:52:22]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-01-20 17:13:06]

https://codereview.chromium.org/1606283003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/format.dart (right):

https://codereview.chromium.org/1606283003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/format.dart:441: List<LinkedUnitBuilder> get units
=> _units ?? const <LinkedUnit>[];
Should we also replace type arguments of the default lists?

[Paul Berry, 2016-01-20 17:31:01]

https://codereview.chromium.org/1606283003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/format.dart (right):

https://codereview.chromium.org/1606283003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/format.dart:441: List<LinkedUnitBuilder> get units
=> _units ?? const <LinkedUnit>[];
On 2016/01/20 17:13:06, scheglov wrote:
> Should we also replace type arguments of the default lists?

Hmm, good question.  Since this is a const list, it probably doesn't matter for
now.

But maybe it would be even better for this line to read:

    List<LinkedUnitBuilder> get units => _units ??= <LinkedUnitBuilder>[];

This would have the advantage of allowing code like the following:

    LinkedLibraryBuilder llb = new LinkedLibraryBuilder();
    llb.units.add(new LinkedUnitBuilder(...));

I'll do some experiments and get back to you.

[Paul Berry, 2016-01-21 17:23:34]

PTAL

[scheglov, 2016-01-21 17:25:40]

LGTM

[Paul Berry, 2016-01-21 19:26:57]

Description was changed from

==========
Modify summary codegen so that builder getters return builders.

This should allow more flexibility in the code that creates summaries,
since it will be possible to things like:

    FooBuilder foo = new FooBuilder(bar: new BarBuilder);
    foo.bar.baz = ...;

(Previously this would have been disallowed because foo.bar would have
returned a `Foo` rather than a `FooBuilder`, and the `Foo` class doesn't
have a setter for `baz`).
==========

to

==========
Modify summary codegen so that builder getters return builders.

This should allow more flexibility in the code that creates summaries,
since it will be possible to things like:

    FooBuilder foo = new FooBuilder(bar: new BarBuilder);
    foo.bar.baz = ...;

(Previously this would have been disallowed because foo.bar would have
returned a `Foo` rather than a `FooBuilder`, and the `Foo` class doesn't
have a setter for `baz`).

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5e27219e9a2db72145be28edf9f754e25c6d0e3b
==========

[Paul Berry, 2016-01-21 19:26:58]

Committed patchset #2 (id:20001) manually as
5e27219e9a2db72145be28edf9f754e25c6d0e3b (presubmit successful).