src/full-codegen/full-codegen.cc - Issue 1606273002: Implement [Generator].prototype.return.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 1606273002: Implement [Generator].prototype.return. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix bug in old code; add more tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index 416a69c708964f5320373ca94c46ed2da6074604..034392bcb465096567c2b2500d18076da86780cd 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -630,6 +630,13 @@ void FullCodeGenerator::EmitGeneratorNext(CallRuntime* expr) {

}

+void FullCodeGenerator::EmitGeneratorReturn(CallRuntime* expr) {

+ ZoneList<Expression*>* args = expr->arguments();

+ DCHECK(args->length() == 2);

+ EmitGeneratorResume(args->at(0), args->at(1), JSGeneratorObject::RETURN);

void FullCodeGenerator::EmitGeneratorThrow(CallRuntime* expr) {

ZoneList<Expression*>* args = expr->arguments();

DCHECK(args->length() == 2);