Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 160627: Fix download cancelling from the save dialog (Closed)

Created:
11 years, 4 months ago by Paul Godavari
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)
Visibility:
Public.

Description

Fix a bug where a download isn't canceled when the user requests it. This particular bug only occurs when the user is prompted via save file dialog and then chooses cancel. In this case, the file selection code path for canceling was not the same as regular cancel case, so the network requests continued. BUG=18160 TEST=When prompted to save a download, choose cancel and notice that there is no further network traffic due to that download. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22557

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M chrome/browser/download/download_manager.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/download/download_manager.cc View 1 3 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Godavari
11 years, 4 months ago (2009-08-05 02:39:01 UTC) #1
Ben Goodger (Google)
11 years, 4 months ago (2009-08-05 23:20:25 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698