[Telemetry] Small fixes in android_app_backend

[Telemetry] Small fixes in android_app_backend

This CL includes two fixes:
- Ensure the app was not running after trying to launch.
- Be more specific when matching process names for the app.

These were split off from:
https://codereview.chromium.org/1510833002/

BUG=

Committed: https://crrev.com/faa44a45efc0ad802d841ed4adebff10a87a0cb1
Cr-Commit-Position: refs/heads/master@{#370704}

[perezju, 2016-01-20 14:17:19]

perezju@chromium.org changed reviewers:
+ aiolos@chromium.org, nednguyen@google.com

[perezju, 2016-01-20 14:17:19]

Ned, Kari, could you review this?

Just a couple of stand-alone fixes for issues I found while developing my new
android benchmark.

[nednguyen, 2016-01-20 17:48:56]

https://codereview.chromium.org/1606243002/diff/1/tools/telemetry/telemetry/i...
File tools/telemetry/telemetry/internal/backends/android_app_backend.py (right):

https://codereview.chromium.org/1606243002/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/backends/android_app_backend.py:95:
'^%s(:|$)' % re.escape(self._default_process_name)).match
Do we have unittest coverage for this?

[aiolos (Not reviewing), 2016-01-20 23:44:14]

https://codereview.chromium.org/1606243002/diff/1/tools/telemetry/telemetry/i...
File tools/telemetry/telemetry/internal/backends/android_app_backend.py (right):

https://codereview.chromium.org/1606243002/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/backends/android_app_backend.py:95:
'^%s(:|$)' % re.escape(self._default_process_name)).match
On 2016/01/20 17:48:56, nednguyen wrote:
> Do we have unittest coverage for this?

No, I don't think we have any unittest coverage for android_app_backend.

[aiolos (Not reviewing), 2016-01-20 23:44:44]

lgtm, but please wait for Ned to review as well.

[nednguyen, 2016-01-21 00:18:07]

https://codereview.chromium.org/1606243002/diff/1/tools/telemetry/telemetry/i...
File tools/telemetry/telemetry/internal/backends/android_app_backend.py (right):

https://codereview.chromium.org/1606243002/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/backends/android_app_backend.py:95:
'^%s(:|$)' % re.escape(self._default_process_name)).match
On 2016/01/20 23:44:14, aiolos wrote:
> On 2016/01/20 17:48:56, nednguyen wrote:
> > Do we have unittest coverage for this?
> 
> No, I don't think we have any unittest coverage for android_app_backend.

Can you add unittest coverage for this method. I always feel a bit uneasy about
using regex without unittest coverage.

[perezju, 2016-01-21 12:25:08]

https://codereview.chromium.org/1606243002/diff/1/tools/telemetry/telemetry/i...
File tools/telemetry/telemetry/internal/backends/android_app_backend.py (right):

https://codereview.chromium.org/1606243002/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/backends/android_app_backend.py:95:
'^%s(:|$)' % re.escape(self._default_process_name)).match
On 2016/01/21 00:18:06, nednguyen wrote:
> On 2016/01/20 23:44:14, aiolos wrote:
> > On 2016/01/20 17:48:56, nednguyen wrote:
> > > Do we have unittest coverage for this?
> > 
> > No, I don't think we have any unittest coverage for android_app_backend.
> 
> Can you add unittest coverage for this method. I always feel a bit uneasy
about
> using regex without unittest coverage.

Done.

[nednguyen, 2016-01-21 14:21:29]

lgtm

[perezju, 2016-01-21 14:25:28]

The CQ bit was checked by perezju@chromium.org

[perezju, 2016-01-21 14:25:29]

The patchset sent to the CQ was uploaded after l-g-t-m from aiolos@chromium.org
Link to the patchset: https://codereview.chromium.org/1606243002/#ps20001
(title: "add unittest")

[commit-bot: I haz the power, 2016-01-21 14:25:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1606243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1606243002/20001

[commit-bot: I haz the power, 2016-01-21 15:54:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-21 15:55:47]

Description was changed from

==========
[Telemetry] Small fixes in android_app_backend

This CL includes two fixes:
- Ensure the app was not running after trying to launch.
- Be more specific when matching process names for the app.

These were split off from:
https://codereview.chromium.org/1510833002/

BUG=
==========

to

==========
[Telemetry] Small fixes in android_app_backend

This CL includes two fixes:
- Ensure the app was not running after trying to launch.
- Be more specific when matching process names for the app.

These were split off from:
https://codereview.chromium.org/1510833002/

BUG=

Committed: https://crrev.com/faa44a45efc0ad802d841ed4adebff10a87a0cb1
Cr-Commit-Position: refs/heads/master@{#370704}
==========

[commit-bot: I haz the power, 2016-01-21 15:55:47]

Patchset 2 (id:??) landed as
https://crrev.com/faa44a45efc0ad802d841ed4adebff10a87a0cb1
Cr-Commit-Position: refs/heads/master@{#370704}