Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: pkg/polymer/test/build/common.dart

Issue 160623002: Updating barback test harness for angular transformers changes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/test/build/common.dart
diff --git a/pkg/polymer/test/build/common.dart b/pkg/polymer/test/build/common.dart
index a4d9ba22e2ce49faca7ad0b34fc0b65de59c16fb..d7ca4151c727ce97e63c681a3711031e580d90b5 100644
--- a/pkg/polymer/test/build/common.dart
+++ b/pkg/polymer/test/build/common.dart
@@ -66,6 +66,8 @@ class TestHelper implements PackageProvider {
});
logSubscription = barback.log.listen((entry) {
+ // Ignore info messages.
+ if (entry.level == LogLevel.INFO) return;
if (entry.level == LogLevel.ERROR) errorSeen = true;
// We only check messages when an expectation is provided.
if (messages == null) return;
@@ -109,11 +111,14 @@ class TestHelper implements PackageProvider {
}
Future checkAll(Map<String, String> files) {
- var futures = [];
- files.forEach((k, v) {
- futures.add(check(k, v));
- });
- return Future.wait(futures).then((_) {
+ return barback.results.first.then((_) {
+ if (files == null) return null;
+ var futures = [];
+ files.forEach((k, v) {
+ futures.add(check(k, v));
+ });
+ return Future.wait(futures);
+ }).then((_) {
// We only check messages when an expectation is provided.
if (messages == null) return;
expect(messages.length, messagesSeen,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698